feat: add Xquik Apify Actor skills - #50
Conversation
…ge case tests - Remove orphaned js-yaml pnpm override (gray-matter was its only consumer) - Add BOM stripping to parseFrontmatter for parity with gray-matter - Wrap parseFrontmatter call in validate-skill-descriptions.ts with try-catch - Add 3 edge case tests: BOM, empty frontmatter, CRLF line endings
Code Review: PR #50 - Xquik Apify Actor SkillsVerdict: Approved with fixes appliedThe PR is well-structured. Both new skills ( I pushed 4 follow-up fixes directly to this branch (maintainer edits enabled). Details below. Fixes Applied (commit 9f67bad)1. Stale The 2.
3. Error handling in The 4. Edge case tests added (scripts/lib/frontmatter.test.ts) Added 3 tests: BOM-prefixed source, empty frontmatter delimiters, and CRLF line endings. All 6 tests pass. Additional Observations (no action needed)
|
Summary
xquik-x-tweet-scraperSkill for 15 public X research modes.xquik-x-follower-scraperSkill for 6 audience relationships and overlap analysis.gray-matterparser with the maintainedyamlparser.Actor Skills
Both Skills use only the Actor listing pages. They validate modes, relationships, and target classes before execution. They also require explicit run confirmation, live pricing review, and a total charge ceiling. Tokens stay in the Authorization header. Diagnostic rows stay separate from research records, and all Actor output remains untrusted data.
The Skills include confirmation and validation dry-runs. No Actor was executed, and no Apify credits were spent.
Repository Improvements
The required PR scripts imported
gray-matter, but the repository override resolves an incompatible modernjs-yamlversion. That causedupdate-readme.ts,validate-pr.ts, andvalidate-skill-descriptions.tsto fail before validating contributions.This PR replaces that dependency with a 28-line shared parser using the maintained
yamlpackage. Three regression tests cover structured YAML, missing frontmatter, and invalid non-mapping documents.The dependency audit also found 2 high-severity advisories. Sharp is updated to 0.35.3, and the PostCSS override now requires a patched release. The final audit reports no known vulnerabilities.
Verification
Tested with the repository's CI versions: Node 22.23.1 and pnpm 9.15.9.
pnpm install --frozen-lockfilepnpm exec tsx scripts/validate-skill-descriptions.tspnpm exec tsx scripts/validate-pr.tspnpm --dir packages/cli run buildpnpm --dir packages/cli run test:e2e: 13 tests passedpnpm audit: no known vulnerabilitiesXquik is an independent third-party service. Not affiliated with X Corp. "Twitter" and "X" are trademarks of X Corp.
Need help on this PR? Tag
@codesmith-botwith what you need. Autofix is disabled.