Refactor/performance improvement#562
Open
smitdylan2001 wants to merge 3 commits into
Open
Conversation
- Change String.Format to Concatenation - Remove FindObjectsSortMode.None, as this is depricated - Make methods static where possible - Use stromg.IsNullOrEmpty where possible - Use local structs instead of array references for many references inside of a loop - Cache FindObjectsByType outside of loops where possible - Merge if-return to single return - Use .AddRange
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some non-breaking performance improvements. This also fixes the obsoleted code, which gave a warning in 6.4, and error in 6.5.
Performance fixes
Big possible future improvements:
If there is interest in that, let me know as well