fix: version check now resolves from user's install source#77
Merged
Conversation
The self-update check previously queried the tap (valkyrie00/bbrew/bbrew), which could show a "New Version Available" notification even when the user installed from homebrew-core and couldn't actually upgrade yet. Now queries "bbrew" directly so it resolves to whichever source the user has. Also adds a Homebrew installs (30d) badge to README and site, sourced from the formulae.brew.sh API via shields.io dynamic JSON badge. Signed-off-by: Vito Castellano <castellano.vito@gmail.com>
Valkyrie00
force-pushed
the
fix/selfupdate-homebrew-core-compat-site
branch
from
4856dfa to
e977b7b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The self-update check previously queried the tap (valkyrie00/bbrew/bbrew), which could show a "New Version Available" notification even when the user installed from homebrew-core and couldn't actually upgrade yet. Now queries "bbrew" directly so it resolves to whichever source the user has.
Also adds a Homebrew installs (30d) badge to README and site, sourced from the formulae.brew.sh API via shields.io dynamic JSON badge.