Refactor promiseTree add an argument to disable warning text#27
Open
emre1791 wants to merge 1 commit into
Open
Refactor promiseTree add an argument to disable warning text#27emre1791 wants to merge 1 commit into
emre1791 wants to merge 1 commit into
Conversation
Owner
|
Thank you for this contribution! I think it might be better if we don't even do Promise.delay() for an input of 0. It just seems unnecessary to insert it into the thread queue for no reason. We just have to make sure the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.