Fix overhead in test report for large test counts#1202
Open
std-max wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After every test,
print_latest_status()calls_split(), which iterates over all accumulated results just to display theP=/S=/F=counters in the progress line.This makes per-test bookkeeping O(n) and cumulative bookkeeping O(n^2), and since it runs inside
_stdout_lockwhile holding the GIL, worker threads progressively block on it.It is particularly visible on large runs: throughput drops and CPU utilization collapses well before the end.
This fix uses three running counters and reads them directly instead of calling
_split().The other two callers of
_split()are left untouched since they need the actual result lists and only run once at the end.