Skip to content

Detail L1#35

Draft
kosack wants to merge 34 commits into
mainfrom
update_l1_figs
Draft

Detail L1#35
kosack wants to merge 34 commits into
mainfrom
update_l1_figs

Conversation

@kosack

@kosack kosack commented Apr 23, 2025

Copy link
Copy Markdown
Member
  • Splits the preliminary L1 diagram into a simple version + several sub-diagrams, with some of the details we discussed in the in-person meeting.
  • Added more detailed connector lines to show the relationship with IVOA ObsCore and DataLink
  • For Pointing and OnTime, where we want to have "single" vs "time-series" versions, uses a "compound" design pattern to link the two (i.e. a "xTimeTeries" is just a list of "xSingle" elements)

kosack added 12 commits April 23, 2025 14:57
started to split out sub-diagrams
no longer specify width, but fix it in the CSS so all diagrams use the
same scale.
I think this is correct, since an observation is not *composed* of them,
it is a concept that collects them. You can have an observation without
anything.
@kosack

kosack commented Apr 29, 2025

Copy link
Copy Markdown
Member Author

Do we want to stick with calling the exposure time intervals "OnTime", or be more general, like TimeInterval or ExposureTime? Also where do the deadtime, etc go? Are they also in that object or separate?


OnTime
------

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

About the OnTime (the previous GTIs), should we add as metadata the dead_time fraction? Or should we put this information (because I think that this is more a data than a metadata) as element of the interval (ie tstart, tstop, deadtime_fraction (optional))?

}

Observation "1" -- "0..1" Pointing
ObsCore .r. Observation : "<<find>> >"

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

its position in the diagram is a bit weird... But it might be difficult to adjust.

package VODF {
class Facility
class Instrument
Facility -- Instrument : <<has>> >

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

its position in the diagram is a bit weird... But it might be difficult to adjust.


package VODF.L1 {

abstract class OnTime

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See above my comment on the deadtime_fraction

@bkhelifi bkhelifi left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Many thanks for the improvements. I put here some comments

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants