feat(PanelHeader,PanelHeaderContext): remove FixedLayout using#9765
Open
EldarMuhamethanov wants to merge 3 commits into
Open
feat(PanelHeader,PanelHeaderContext): remove FixedLayout using#9765EldarMuhamethanov wants to merge 3 commits into
EldarMuhamethanov wants to merge 3 commits into
Conversation
Contributor
size-limit report 📦
|
Contributor
e2e tests |
Contributor
Contributor
👀 Docs deployed
📦 Package ✅yarn add @vkontakte/vkui@https://development.s3.prodcloud.vk.team/pull/9765/84be8fbf094b36dab013c6c3418d16ff10e1e3e9/pkg/@vkontakte/vkui/_pkg.tgzCommit 84be8fb |
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## master #9765 +/- ##
==========================================
- Coverage 95.30% 95.22% -0.08%
==========================================
Files 441 443 +2
Lines 12146 12237 +91
Branches 4416 4438 +22
==========================================
+ Hits 11576 11653 +77
- Misses 570 584 +14
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
SevereCloud
reviewed
Apr 29, 2026
Contributor
There was a problem hiding this comment.
Контекст теперь не влезает по ширине
2026-04-29.11.28.19.mov
|
|
||
| export interface BoxProps extends Omit<RootComponentProps<HTMLElement>, 'Component'>, LayoutProps { | ||
| /** | ||
| * |
| /> | ||
| <div | ||
| data-testid={process.env.NODE_ENV === 'test' ? 'content' : undefined} | ||
| <Popover |
Contributor
There was a problem hiding this comment.
nit: Насколько мы можем отказаться от Popover-а?
Contributor
Author
There was a problem hiding this comment.
вообще можно оставить старую реализации всплывашки, но в issue привязанном написано переписать на Popover
vkcom-publisher
added
pr-needs-work
vkcom-publisher
added
the
pr-needs-work
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
FixedLayout#9357Описание
Избавился от
FixedLayoutвPanelHeaderиPanelHeaderContext. ВPanelHeaderContextиспользовалPopoverТакже в
Boxдоработал свойствоComponent, чтобы можно было прокидывать несколько декораторовRelease notes
Улучшения
FixedLayoutв реализации компонентаFixedLayoutв реализации компонента