Skip to content

Fix RTP node compilation with libre 3.24#955

Merged
stv0g merged 2 commits into
masterfrom
fix-node-rtp
Sep 5, 2025
Merged

Fix RTP node compilation with libre 3.24#955
stv0g merged 2 commits into
masterfrom
fix-node-rtp

Conversation

@pjungkamp

Copy link
Copy Markdown
Contributor

This bug was introduced by baresip/re#1357

Comment thread include/villas/nodes/rtp.hpp Outdated
stv0g
stv0g previously approved these changes Sep 3, 2025

@stv0g stv0g left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a tiny nit

@stv0g

stv0g commented Sep 3, 2025

Copy link
Copy Markdown
Contributor

This fix is also included in #954.
But I will merge your PR first and rebase #954 after.

Signed-off-by: Philipp Jungkamp <philipp.jungkamp@rwth-aachen.de>
@stv0g

stv0g commented Sep 3, 2025

Copy link
Copy Markdown
Contributor

I did the fix and rebased this PR to master

Signed-off-by: Philipp Jungkamp <philipp.jungkamp@rwth-aachen.de>
@pjungkamp

Copy link
Copy Markdown
Contributor Author

I just removed the comment entirely.

libre doesn't use include guards and doesn't declare transitive dependencies in any of their headers. I don't like it but this seems to be the way it's intended to be used and thus not-a-bug in libre.

@stv0g

stv0g commented Sep 3, 2025

Copy link
Copy Markdown
Contributor

As a library user we should probably only include re/re.h which has the guard.

We are not doing it due a colliding identifier with libjansson.

@stv0g stv0g merged commit 6d01c56 into master Sep 5, 2025
3 checks passed
@stv0g stv0g deleted the fix-node-rtp branch September 5, 2025 08:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants