[SECURITY] Fix XSS sanitization gaps in DeviceCard — closes #8 - #38
Merged
elizabetheonoja-art merged 3 commits intoJun 23, 2026
Merged
Conversation
Part of fix for issue Utility-Protocol#8 — XSS sanitization for device labels.
Apply sanitize() to metrics keys and values (previously unsanitized). Import sanitize/validateLabel from shared utility. Fixes issue Utility-Protocol#8.
Covers sanitize() and validateLabel() with known attack vectors including script tags, javascript: URIs, and on* event handlers. Fixes issue Utility-Protocol#8.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #8 — DOM XSS sanitization for device meter labels.
Changes:
sanitize()andvalidateLabel()tosrc/utils/sanitize.ts(shared, testable)DeviceCard.tsxto import from the shared utilitysanitize()to metrics values (previously unsanitized —String(value)was passed raw)tests/unit/sanitize.test.tscovering all XSS vectors from the issueSecurity impact
Before this fix, the
metricsrecord values were rendered via{String(value)}without sanitization. While React's JSX escaping prevents direct script injection, applying sanitize() provides defense-in-depth against:<script>/<img onerror=>payloadsjavascript:URI schemeson*=event handler injectionsAll three entry points (
label,location,metrics.key,metrics.value) are now sanitized.Test coverage
Checklist
""for dangerous-only inputsvalidateLabeluseMemoused forsafeLabelandsafeLocationtests/**/*.test.ts)