fix: sync session lifespan watches directly to hardware key constraints - #24
Merged
elizabetheonoja-art merged 1 commit intoJun 16, 2026
Conversation
The monitorWalletLock function previously polled the session storage (utility-session) to detect wallet disconnection, which meant the backend API session remained active even after wallet disconnect until the TTL expired. Now monitorWalletLock checks the actual wallet connection state (utility-wallet-session) directly. When the wallet is disconnected, the session is destroyed immediately, preventing unauthorized access from unattended machines. Closes Utility-Protocol#22
elizabetheonoja-art
pushed a commit
that referenced
this pull request
Jul 22, 2026
Add webhook delivery service with signed retries
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
When a user locks or disconnects their browser-based wallet, the backend API session remains active. \monitorWalletLock\ was polling the session storage (\utility-session) rather than the actual wallet connection state. A malicious actor with access to the unattended machine could continue performing authenticated actions until the session timer expired.
Solution
Added \isWalletConnected(address)\ helper that reads the actual wallet connection state from \utility-wallet-session\ (the key used by \WalletProvider). Updated \monitorWalletLock\ to poll wallet existence via this helper and call \destroySession()\ immediately when the wallet is gone.
Changes
Closes #22