Some more OAM + misc.#405
Open
assidion2 wants to merge 46 commits into
Open
Conversation
UsernameFodder
requested changes
Jun 27, 2026
| // 2 bytes | ||
| uint16_t offset_x : 9; // The value to be used is this - 256, which can end up negative. | ||
| bool likely_padding_2 : 1; | ||
| bool unk5 : 1; |
Owner
There was a problem hiding this comment.
Can we keep this the same? I don't like this counter numbering scheme for this reason (figuring out something means there will either be gaps or the numbers will have to shift up), but since it was already this way, I'd rather prioritize keeping the names stable over removing gaps in the numbering.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.