Duskull, Kecleon, Kangaskhan Overlays + Peripherals#404
Conversation
Tests are passing on my end. Somehow I have those now?
The headers look like a nightmare to properly format without actual clang. So I'll pass on that for now.
Co-authored-by: UsernameFodder <93669634+UsernameFodder@users.noreply.github.com>
Co-authored-by: UsernameFodder <93669634+UsernameFodder@users.noreply.github.com>
…ppy1/pmdsky-debug into Spring-Cleaning-SwapShop
There was a problem hiding this comment.
You can also probably document the inner function FUN_0200d398 as MaybeGetFormattedItemName
params 1-3: same as in your functions
param 4: should_color_name (bool)
param 5: space_align_non_sticky_items (bool, whether to add an extra space before non sticky items to align them with sticky ones)
Co-authored-by: UsernameFodder <93669634+UsernameFodder@users.noreply.github.com>
| address: | ||
| EU: 0x23258EC | ||
| length: | ||
| EU: 0x4 |
There was a problem hiding this comment.
If the bool is loaded as a word, should I just make it an int? It's clearly only ever zero or one. Is there a "wide bool" type I could use instead?
There was a problem hiding this comment.
In that case, just using an int is fine
| address: | ||
| EU: 0x23258F4 | ||
| length: | ||
| EU: 0x4 |
There was a problem hiding this comment.
If bool,
| EU: 0x4 | |
| EU: 0x1 |
| Exclusively passed into MaybeGetUncoloredFormattedItemName and MaybeGetColoredFormattedItemName. | ||
| The exact purpose of this struct is unknown, but the only "true" bool in the table is for "Other" items. | ||
|
|
||
| type: bool |
| Allocates a currently unknown struct of size 0x410 at UNK_STORAGE_STRUCT_0X410_PTR. May be a state case structure of some kind. | ||
| Likely used by Kangaskhan Storage, or some other storage interaction menu. | ||
|
|
||
| r0: undefined2 |
There was a problem hiding this comment.
Header says this is a pointer? Which is right?
| description: |- | ||
| Seems to handle loading overlay 22 for the kecleon brothers shop. Is used by both colors of Kecleon. | ||
|
|
||
| r0: 1 for purple kecleon, 0 for green kecleon. |
There was a problem hiding this comment.
If this is confidently known, give the param a name in the header
| description: |- | ||
| Seems to handle loading overlay 23 for Kangaskhan storage, as well as Kangaskhan rock storage. | ||
|
|
||
| r0: 2 for kangaskhan rock, 0 otherwise? |
There was a problem hiding this comment.
The header says this is a bool, but a bool can't take the value 2. So is it an int instead?
|
|
||
| r0: unused | ||
| r1: int | ||
| r2: uint |
There was a problem hiding this comment.
The header says this is a uint32_t*, which is right?
|
|
||
| r0: unused | ||
| r1: int | ||
| r2: uint |
There was a problem hiding this comment.
The header says this is a uint32_t*, which is right?
| Does nothing if "KANGASKHAN_STORAGE_MENU_PTR->is_kanga_rock" is true. | ||
|
|
||
| r0: window_id | ||
| r1: preprocessor_flags pointer |
There was a problem hiding this comment.
Header says this is a value-type struct preprocessor_flags. Which is right? I would assume a pointer?
3 participants
No description provided.