Closed
Add explicit decision/fallback logging in Book.from_isbn#106
Book.from_isbn#106Conversation
User0332
marked this pull request as ready for review
May 29, 2026 04:10
Copilot
AI
changed the title
[WIP] Add logging to the Book.from_isbn method
Add explicit decision/fallback logging in May 29, 2026
Book.from_isbn
User0332
requested changes
May 29, 2026
|
|
||
| if isbnlib.is_isbn10(isbn): | ||
| logger.info(f"Decision: from-isbn - Converting ISBN-10 to ISBN-13. isbn={isbn}") | ||
| logger.info(f"Decision: from-isbn - Converting ISBN-10 to ISBN-13. isbn={safe_isbn}") |
Owner
There was a problem hiding this comment.
Remove "decision" from the string
|
|
||
| @staticmethod | ||
| def from_isbn(isbn: str) -> "Book": | ||
| def sanitize_log_value(value: str) -> str: |
Owner
There was a problem hiding this comment.
delete this, we don't need to sanitize the ISBN
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Book.from_isbnlacked visibility into fallback/error branches, making ISBN lookup/debug flows opaque in production logs. This update adds explicit logs for branch decisions and fallback failures while preserving existing behavior.Logging coverage in
Book.from_isbnLog safety hardening
Representative snippet