Improve GCP review evidence scope handling#2085
Open
DENGXUELIN wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
/claim #41
Summary
Improves
gcp-reviewso posture reports qualify organization, folder, project, resource, policy, SCC, and subnet scope before assigning broad results.Changes include:
GCP-EVID-SCOPE-01throughGCP-EVID-SCOPE-08gates for evidence source, denominator tracking, IAM allow/deny/PAB distinction, Organization Policy inheritance, SCC tier/scope, VPC Flow Logs subnet coverage, Not Evaluable reason codes, and exception/retest handling.Why
A project-level Terraform file, sampled Cloud Asset Inventory export, or project SCC finding can be useful evidence, but it does not prove organization-wide compliance by itself. The new gates keep GCP CIS findings scoped to the evidence actually reviewed.
Validation
git diff --check origin/main...HEADgit merge-tree --write-tree origin/main HEADskills/cloud/gcp-review/SKILL.mdGCP-EVID-SCOPE-01throughGCP-EVID-SCOPE-08Bounty Info
CONTRIBUTING.mdbounty terms.