Add SharesHook hook on ethereum#656
Open
hooklist-generator[bot] wants to merge 1 commit into
Open
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
There was a problem hiding this comment.
Review: hooks/ethereum/0x42ac35d497d63abab6e3efa9b0f7b0c76ab5c4cc.json
Flags — PASS
Address last 14 bits: 0xc4cc & 0x3fff = 0x04cc = 0b00_0100_1100_1100
All 14 flags match both the address bitmask and getHookPermissions() in source:
- afterAddLiquidity=true (bit10) ✓
- beforeSwap=true (bit7) ✓
- afterSwap=true (bit6) ✓
- beforeSwapReturnsDelta=true (bit3) ✓
- afterSwapReturnsDelta=true (bit2) ✓
- All others false ✓
Properties — PASS
- dynamicFee=false:
_beforeSwapreturns0for the fee parameter; noupdateDynamicLPFee()call. Fees are taken as BeforeSwapDelta/AfterSwapDelta amounts, not LP fee overrides. ✓ - upgradeable=false: No proxy pattern, delegatecall, mutable implementation pointer, or SELFDESTRUCT. ✓
- requiresCustomSwapData=false:
hookDatais decoded optionally in_swapTrader()for trader attribution; gracefully falls back totx.origin/senderwhen empty. Swaps function correctly without hookData. ✓ - vanillaSwap=false: Correct — hook returns non-zero BeforeSwapDelta (buy fee) and non-zero AfterSwapDelta (sell fee), materially altering swap cash flows. ✓
- swapAccess="none":
_beforeSwaphas no caller-based access control. Non-tracked pools (wrong fee/tickSpacing/tokens) pass through silently; tracked pools have no allowlist, governance flag, or temporal gate. ✓
Metadata — PASS
- verifiedSource=true: Confirmed by
source_meta.json("verified": true). ✓ - chainId=1: Ethereum mainnet. ✓
- name="SharesHook": Matches contract name in source. ✓
- description: Accurately reflects the source logic — 2.5% buy and sell fees (
BUY_FEE_PPM = SELL_FEE_PPM = 25_000 / 1_000_000), random seed update on every swap, external launch controller notification via_recordSwapActivity, and token start triggered by firstafterAddLiquidityonce config is finalized. No marketing, audit, or safety language. ✓
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Collects protocol fees (2.5% each) on buy and sell swaps for a designated native/token pool, updates an on-chain random seed on each swap, and notifies an external launch controller of swap activity. Triggers a token start on first liquidity addition once config is finalized.
Flags
Properties
Warnings
Closes #655