Skip to content

bugfix: 12hr clock and settings menu#12

Open
ruthsarian wants to merge 2 commits into
UnexpectedMaker:masterfrom
ruthsarian:bugfix-12hr-clock-and-settings
Open

bugfix: 12hr clock and settings menu#12
ruthsarian wants to merge 2 commits into
UnexpectedMaker:masterfrom
ruthsarian:bugfix-12hr-clock-and-settings

Conversation

@ruthsarian

Copy link
Copy Markdown

WOPR_Display_V2 bugfixes:

  • 12 hour clock mode the hour was displaying the hour as "0" and not "12" at midnight
  • removed "NGHT DIM" from settingsStrings[] as the dim at night setting is not implemented; there is no entry for it in enum setings{} which throws off the settings display as it uses the value of currentSetting to index settingsStrings[] to pick what string to display to represent the current setting.

WOPR_Display_V2 code change:

  • made use of the ELEMENTS() macro when detecting if the current clock separator setting index is outside the number of available clock separator values rather than using hard-coded values. this makes it easier to add new separators.

fix so at midnight, the 12 hour clock displays "12" and not "0".
Removed "NGHT DIM " from settingsStrings[] as no equivalent setting for this exists in enum settings{}, which is causing errors when using settings menu. Also applied ELEMENTS() macro to detect how many clock separator options there are rather than using hard-coded values.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant