Improved gaussian2d estimator#37
Closed
Geegee wants to merge 5 commits into
Closed
Conversation
Neverhorst
removed their request for review
June 18, 2026 19:09
Member
|
@Geegee @timoML @anjusha-vs @TobiasSpohn Is this still relevant or can I close it. If it is only an improvement for certain special use-cases, it could be an option to include it in qudi-iqo-modules instead. |
Removed unused logger initialization from gaussian.py
Contributor
|
I have never used this improved estimator, for me the standard one worked sufficiently well enough. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Trying to improve the estimator for the 2 D gaussian fit function
Description
Transform the recorded counts into a probability distribution.
Estimate mean and variance from that.
Motivation and Context
Can help when the photon source moved quiet a bit from the previous
position.
How Has This Been Tested?
On the dummy. Ideally this would get some testing in action.
Although the method to estimate was already used in the old qudi.
Screenshots (only if appropriate, delete if not):
Types of changes
Checklist:
/docs/changelog.md.(syntax, indentation, mutable default values, etc.).