Skip to content

Improved gaussian2d estimator#37

Closed
Geegee wants to merge 5 commits into
mainfrom
improved_gaussian2d_estimator
Closed

Improved gaussian2d estimator#37
Geegee wants to merge 5 commits into
mainfrom
improved_gaussian2d_estimator

Conversation

@Geegee

@Geegee Geegee commented Nov 21, 2022

Copy link
Copy Markdown
Contributor

Trying to improve the estimator for the 2 D gaussian fit function

Description

Transform the recorded counts into a probability distribution.
Estimate mean and variance from that.

Motivation and Context

Can help when the photon source moved quiet a bit from the previous
position.

How Has This Been Tested?

On the dummy. Ideally this would get some testing in action.
Although the method to estimate was already used in the old qudi.

Screenshots (only if appropriate, delete if not):

Types of changes

  • Bug fix
  • New feature
  • Breaking change (Causes existing functionality to not work as expected)

Checklist:

  • My code follows the code style of this project.
  • I have documented my changes in /docs/changelog.md.
  • My change requires additional/updated documentation.
  • I have updated the documentation accordingly.
  • I have added/updated the config example for any module docstrings as necessary.
  • I have checked that the change does not contain obvious errors
    (syntax, indentation, mutable default values, etc.).
  • I have tested my changes using 'Load all modules' on the default dummy configuration.
  • All changed Jupyter notebooks have been stripped of their output cells.

@Neverhorst
Neverhorst removed their request for review June 18, 2026 19:09
@Neverhorst

Copy link
Copy Markdown
Member

@Geegee @timoML @anjusha-vs @TobiasSpohn Is this still relevant or can I close it.
If someone wants to merge it, please review and evaluate if this change is an improvement. Since I do not work in the lab anymore, I do not want to make assumptions about the usability over the default estimator.

If it is only an improvement for certain special use-cases, it could be an option to include it in qudi-iqo-modules instead.

@TobiasSpohn

Copy link
Copy Markdown
Contributor

I have never used this improved estimator, for me the standard one worked sufficiently well enough.

@Neverhorst Neverhorst closed this Jul 18, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants