feat(apollo-vertex): add expand/collapse-all toggle to data table header#788
Merged
frankkluijtmans merged 1 commit intoJun 8, 2026
Merged
Conversation
Contributor
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
Dependency License Review
License distribution
Excluded packages
|
There was a problem hiding this comment.
Pull request overview
Adds an expand/collapse-all control to the shared Apollo Vertex DataTable header when row expansion is enabled and an "expand" column is present, along with new i18n strings for the toggle labels.
Changes:
- Render an icon-only expand/collapse-all toggle in the
"expand"column header that callstable.toggleAllRowsExpanded(). - Add distinct double-chevron icons for the header toggle to differentiate it from per-row expand controls.
- Add
expand_all/collapse_alltranslation keys toapps/apollo-vertex/locales/en.json.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| apps/apollo-vertex/registry/data-table/data-table.tsx | Adds header-level expand/collapse-all UI and supporting imports/logic for expandable tables. |
| apps/apollo-vertex/locales/en.json | Adds English strings for the expand/collapse-all toggle labels. |
frankkluijtmans
force-pushed
the
frankkluijtmans/data-table-expand-collapse-all
branch
from
7dd0178 to
0998700
Compare
When a table has expandable rows (renderExpandedRow set) and a dedicated leftmost expand column (id "expand"), render an expand/collapse-all toggle in that column's header, aligned above the per-row chevrons. - uses table.toggleAllRowsExpanded() / getIsAllRowsExpanded() on the table instance, so it works with the existing uncontrolled expansion - distinctive double-chevron icons (ChevronsUpDown / ChevronsDownUp) to set it apart from the per-row single chevron - labels via t(expand_all / collapse_all) with defaultValue fallbacks - locales/en.json: add expand_all and collapse_all keys Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
frankkluijtmans
force-pushed
the
frankkluijtmans/data-table-expand-collapse-all
branch
from
0998700 to
6847099
Compare
ruudandriessen
approved these changes
Jun 8, 2026
frankkluijtmans
deleted the
frankkluijtmans/data-table-expand-collapse-all
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds an expand/collapse-all toggle to the shared
DataTableheader, split out of #782 to keep that PR focused on the Solution Tests template.renderExpandedRowset) and a dedicated leftmost expand column (id: "expand"), the header renders an expand/collapse-all toggle aligned above the per-row chevrons.ChevronsUpDown/ChevronsDownUp) to set it apart from the per-row single chevron.table.toggleAllRowsExpanded(); no consumer changes required.