application form errors, navbar fixes#137
Merged
Merged
Conversation
ebinbellini
requested changes
May 13, 2026
ebinbellini
left a comment
ebinbellini
left a comment
There was a problem hiding this comment.
Ready to merge once you fix this one bug
ebinbellini
approved these changes
May 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR attempts to solve several issues.
Firstly the "Save draft" button previously was not clickable if not all required fields where entered. This has now been changed so that the button always clickable, so you can always save your progress. (THERE IS NO GIT ISSUE)
Similarly, the "Submit" button previously was not clickable if not all required fields where entered. This has also been changed so that the button is always clickable, so that you can always attempt to submit. However if a required field has not been entered, then clicking submit will highlight does boxes with a red border and also display a red helper text next to these boxes. The red boxes and helper text disappear as soon as your start typing in them. closes
Required have a red asterix added to them, indicating their "requiredness".
The email and phone-number field are validated and helper text is shown if they are not formatted correctly.
Below these two fields we also have some helper text to explain that either of this options is required, meaning you need to have at least one of them. #115
Also the UTN logo link now takes you to the home page of apply (this website) instead of to the UTN homepage. (THERE IS NO GIT ISSUE)
The hamburger menu was rendered off-screen resulting in tab navigation ending up off screen and Z-index caused the X icon to not be shown. This has now been fixed. (THERE IS NO GIT ISSUE)