More button animations#128
Merged
Merged
Conversation
We already had the loading prop for <Button>. This change makes every button that should show a loading state actually use this prop. Added the animation to: - Login button - Save draft button - Submit application button - Change password modal primary button - Delete account modal primary button Also changed some <a> to <Link>
SebbeBlom
approved these changes
May 12, 2026
SebbeBlom
left a comment
SebbeBlom
left a comment
There was a problem hiding this comment.
Looks great, just one piece of what i think is dead code we might what to remove it while at it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We already had the loading prop for . This change makes every button that should show a loading state actually use this prop.
Added the animation to:
Also changed some to
Closes #124