355 bug c17 form unpublishing broken#357
Open
AidanLoran wants to merge 4 commits into
Open
Conversation
chanabyte
reviewed
Jun 13, 2026
chanabyte
left a comment
chanabyte
left a comment
Collaborator
There was a problem hiding this comment.
Looks good from what I have seen. It would be a good idea to make a comment on how "unpublished" basically means "nonactive" and how being "published" is measured with t/f. I will make a comment below about it.
Co-authored-by: Swarna Sre <67798786+chanabyte@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
changed function toggleStatus in admin.ts to send a put request to api/form/[id].put.ts (from in-progress h4 issue) to actually update the status of a form server-side
also made a quick change to the api/form/index.ts action 'getOnlyActiveFormsInGroup'. Now,, it and the reader will only query for published forms, fixing unpublish/publish reader side.