GCP budget fixes#176
Merged
Merged
Conversation
Contributor
|
This was the reason we didn’t have any years before 2016. I wasn’t entirely aware but good catch. |
mikehquan19
approved these changes
Jun 5, 2026
Member
Author
|
Oh I think they just didn't have any published before 2016 but yeah, ty |
Contributor
|
Lol really? I could’ve sworn I saw 2013-2016 in the static-data dir. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The monthly budget runner failed on GCP. Turns out it's cause the Dockerfile doesn't copy the static-data folder over into the build. That was a quick fix.
In testing tho, none of the budget caching worked and a bunch of new expensive Gemini calls were made. I'd like to avoid that so I'm proposing doing the cache by year instead of a hash. I've renamed the already cached files in the bucket and updated the warning in the code to indicate that any changes will not take effect until the cached result is cleared from the bucket