issue #633

[ferribyh]

updating TADA_ConvertSpecialChars() so that records with missing or blank result units are removed when clean = TRUE and ResultMeasureValue is being converted

Changes:
-Added a check in TADA_ConvertSpecialChars() to remove rows where TADA.ResultMeasure.MeasureUnitCode is missing or blank during ResultMeasureValue conversion when clean = TRUE
-Limited the new filtering behavior to the ResultMeasureValue workflow so that conversions of other columns are unaffected
-Added a unit test covering the new cleaning behavior

Pull Request Checklist (convert PR to draft if in progress)

Required

• Update your branch from the latest develop and resolve any merge conflicts

• Run devtools::test(), devtools::check(), and devtools::document() locally; ensure tests pass and fix any errors, warnings, or notes. Add new dependencies to DESCRIPTION and document appropriately

• Add/update vignettes for corresponding changes in functionality, list these under articles in _pkgdown.yml, and ensure added/updated vignettes run and build with proper formatting locally

• Request review from at least one developer team member (convert PR to ready for review if it was designated as in progress)

Best practices

• Include a summary of the changes made and relevant context/motivation

• Link issues to auto-close on merge (use Development sidebar or include "Closes #" in the PR)

• Refresh inline/block comments for clarity

• Update roxygen docs and include examples; review help pages

• Add/update tests in tests/testthat; review the bot's coverage report from test-coverage and confirm all changes are covered

Conditional

• If there is a bot spelling comment, run spelling::spell_check_package() locally and fix any misspellings; add approved project terms to WORDLIST with spelling::update_wordlist()

• If tests fail suggesting internal reference files need a refresh, run .TADA_UpdateRefFiles() and .TADA_UpdateExampleData() locally via MaintenanceScheduled.R or trigger the Component File Update GitHub Action

• If new example data files were added, document them in ExampleData.R and include them in MaintenanceScheduled.R for regular refresh

• If columns were added/updated, update RequiredCols.R

• If changes affect other package or the shiny app functions, update those impacted functions accordingly

[github-actions]

coverage-report

File	Coverage		Missing
All files	67%	✅
R/Utilities.R	70%	✅	543 661-662 666 671-673 768 1081-1083 1151-1152 1206-1210 1320-1321 1325-1326 1336-1340 1345-1350 1392-1546 1640 1697 1705 1766 1774-1794 1820-1821 1830-1844 1868-1871 1935-1936 1953-1955 1960 1963-1965 2049-2127 2158-2160 2196-2364 2391-2395 2404-2408 2625 2678 2684-2687 2691 2702 2721-2722 2724-2739 2741 2743 2749 2752-2754 2756 2761 2776 2782 2790 2795 2803-2808 2837 2847-2849 2870-2874 2884-2886 2889-2894 2898-2903 2911 2921-2922 2933 2949 2981-3015 3130 3139 3178-3182

Minimum allowed coverage is 20%

Generated by 🐒 cobertura-action against cef2678

[cristinamullin]

Rows with numeric Result Values but NA units should be flagged accordingly when clean = F.

Currently, it looks like the TADA.ResultMeasureValueDataTypes.Flag will show it as 'numeric'. and when clean = F. Those those rows are kept which is good, but the flag is not detailed enough. When clean = T that row will get removed which is the expected behavior.

Can you please update the flag when clean = F for rows that have blank units to be "No unit associated with result value"? That way we can leverage it for tracking row removal reasons in TADAShiny.

Thanks!

[ferribyh]

I added a flag type called "No unit associated with result value" and added two tests for this flag type