954 create helper function to auto populate the saltfresh column in tada criteria and methodologies template for users

[hillarymarler]

Closes #954

Adds TADA_SaltFreshIndicator which populates the TADA.SaltFreshIndicator column to support mod 2 workflow and provide salt/fresh info for criteria in Mod 3.

This function will be added to an expanded Mod 2 vignette update in the near future.

This PR adds:

1. TADA_SaltFreshIndicator function
2. tests for the new function2
3. Csv files in extdata to support crosswalking of salt/fresh indicator to ATTAINS.WaterType and TADA.MonitoringLocationIdentifierTypeName

Reviewing the reference table I added to crosswalk to the saltfresh indicator by water type as well as the funciton itself would be helpful. I really was not sure what to to with estuaries - should they get their own indicator value?

Pull Request Checklist (convert PR to draft if in progress)

Required

• Update your branch from the latest develop and resolve any merge conflicts

• Run devtools::test(), devtools::check(), and devtools::document() locally; ensure tests pass and fix any errors, warnings, or notes. Add new dependencies to DESCRIPTION and document appropriately

• Add/update vignettes for corresponding changes in functionality, list these under articles in _pkgdown.yml, and ensure added/updated vignettes run and build with proper formatting locally

• Request review from at least one developer team member (convert PR to ready for review if it was designated as in progress)

Best practices

• Include a summary of the changes made and relevant context/motivation

• Link issues to auto-close on merge (use Development sidebar or include "Closes #" in the PR)

• Refresh inline/block comments for clarity

• Update roxygen docs and include examples; review help pages

• Add/update tests in tests/testthat; review the bot's coverage report from test-coverage and confirm all changes are covered

Conditional

• If there is a bot spelling comment, run spelling::spell_check_package() locally and fix any misspellings; add approved project terms to WORDLIST with spelling::update_wordlist()

• If tests fail suggesting internal reference files need a refresh, run .TADA_UpdateRefFiles() and .TADA_UpdateExampleData() locally via MaintenanceScheduled.R or trigger the Component File Update GitHub Action

• If new example data files were added, document them in ExampleData.R and include them in MaintenanceScheduled.R for regular refresh

• If columns were added/updated, update RequiredCols.R

• If changes affect other package or the shiny app functions, update those impacted functions accordingly

[github-actions]

Spelling check failed. Details:

Spelling check failed. Found 1 potential misspelling(s). Note: Run spelling::spell_check_package() locally and fix any misspellings; add approved project terms to WORDLIST with spelling::update_wordlist().

  WORD                 FOUND IN
SaltFreshIndicator   TADA_SaltFreshIndicator.Rd:28

[github-actions]

Spelling check failed. Details:

Spelling check failed. Found 1 potential misspelling(s). Note: Run spelling::spell_check_package() locally and fix any misspellings; add approved project terms to WORDLIST with spelling::update_wordlist().

  WORD                 FOUND IN
SaltFreshIndicator   TADA_SaltFreshIndicator.Rd:28

[github-actions]

coverage-report

File	Coverage		Missing
All files	67%	✅
R/ATTAINSCrosswalks.R	52%	✅	32-876 1101-1105 1110-1115 1120-1123 1128-1159 1165-1168 1174-1177 1191-1194 1205-1220 1266-1269 1513-1514 1521-1522 1527-1528 1555-1562 1693 2016-2019 2024 2053-2057 2069-2072 2080 2089-2096 2111-2120 2125-2133 2139-2162 2182-2197 2202-2205 2210-2241 2254-2257 2329-2333 2428-2437 2653-2654 2723 2894-2900 3120-3698 3876-3879 3887-3892 3898-3918 3926-3930 3943-3947 3978-4087 4139-4294 4299-4302 4363-4364 4400 4476-4482 4601 4678-4680 4684-4686 4722-4767 4824-4826

Minimum allowed coverage is 20%

Generated by 🐒 cobertura-action against 7d61197