278 corps castle link not redirecting correctly#281
Merged
willbreitkreutz merged 4 commits intoMay 18, 2026
Conversation
… Remove any logic from breadcrumb items, just use the href provided.
…usace logo in the header, just pass that href down, or if not provided bail with a `#`
|
Please set a versioning label of either |
krowvin
requested changes
May 11, 2026
krowvin
left a comment
krowvin
left a comment
Contributor
There was a problem hiding this comment.
Seems we both took a crack at this!
I should have assigned I only set it as a child issue
Also good we both did because I did not go the route of adding the home link param. Agreed on that.
But consider the default. If you believe it should be # ?
krowvin
approved these changes
May 18, 2026
willbreitkreutz
added a commit
that referenced
this pull request
Jun 2, 2026
* Run at /groundwork locally to better emulate docs site * Modify docs template to make home button and breadcrumbs work better. Remove any logic from breadcrumb items, just use the href provided. * Add a `homeUrl` prop to the site wrapper that drives the href of the usace logo in the header, just pass that href down, or if not provided bail with a `#` * add `homeUrl` prop to SiteWrapper docs
willbreitkreutz
added a commit
that referenced
this pull request
Jun 8, 2026
* initial commit for maps * styles update * fixed old type * fixed library name * fixed conflicts * Update publish.yml (#276) * run npm audit fix (#275) * 4.0.6 * Update publish.yml (#277) * 4.0.7 * try updated checkout action (#279) * 4.0.8 * Update publish (#280) * try updated checkout action * add repository to package.json? * 4.0.9 * Update publish.yml try and get the npm logs * Update publish.yml * Update publish.yml Remove debug step * 278 corps castle link not redirecting correctly (#281) * Run at /groundwork locally to better emulate docs site * Modify docs template to make home button and breadcrumbs work better. Remove any logic from breadcrumb items, just use the href provided. * Add a `homeUrl` prop to the site wrapper that drives the href of the usace logo in the header, just pass that href down, or if not provided bail with a `#` * add `homeUrl` prop to SiteWrapper docs * 4.1.0 * Fix duplicated docs hash links (#282) * 4.1.1 * try and get up to date package lock * update groundwork-geo * remove annoying type errors * change from console.log to alert, that way we show the user click handler is doable * swap alert for console.log * make mapping navigation links consistent * Fix mapping section of links in nav-links.js * add demo imports for the components being used * fix demo import for GeoJSONLayer * Update map-layout docs Note that it is leftSidebar and the other overlays are ...Toolbar --------- Co-authored-by: thill02 <tessa.j.hill@usace.army.mil> Co-authored-by: Charles Graham <charles.r.graham@usace.army.mil>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix a couple of the link issues. This should solve the breadcrumbs not working #273 and the corps castle link issue #278 .
Checklist
patch-bump,minor-bump, ormajor-bumpRelease impact
Should not have any breaking changes, but adds to the api of SiteWrapper