Skip to content

Devops/release adr and docs#1765

Open
MikeNeilson wants to merge 3 commits into
developfrom
devops/release-adr-and-docs
Open

Devops/release adr and docs#1765
MikeNeilson wants to merge 3 commits into
developfrom
devops/release-adr-and-docs

Conversation

@MikeNeilson

Copy link
Copy Markdown
Contributor

Summary

Create ADR for handling releases.

Related Issue

N/A

Validation

Review

Checklist

  • AI tools used

@msweier msweier left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense to me.

@krowvin krowvin left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Consider a link to this doc from the Readme / adding to the cda-gui.

@adamkorynta adamkorynta left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I recommend defining the term tag throughout this ADR. Since the release process involves both git tags and container image tags, I get a little confused when matching up against the GitHub workflows.

Additionally, in the deployment descriptions I'd add in:

  • which Git refs commits are expected to be tagged from i.e. release/hotfix branches (specifically not develop)
  • which environments are deployed automatically on an automated schedule versus manually triggered

Comment thread docs/source/decisions/0009-code-changes-and-releases.rst Outdated
Comment thread docs/source/decisions/0009-code-changes-and-releases.rst Outdated
Comment thread docs/source/decisions/0009-code-changes-and-releases.rst Outdated
Comment thread docs/source/decisions/0009-code-changes-and-releases.rst Outdated
Co-authored-by: Adam Korynta <47677856+adamkorynta@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants