Skip to content

Remove 'source' from the FTP put condition - #80

Open
nicolasCtd wants to merge 1 commit into
UMR-CNRM:extract-ftservfrom
nicolasCtd:remove_source_from_put_condition
Open

Remove 'source' from the FTP put condition#80
nicolasCtd wants to merge 1 commit into
UMR-CNRM:extract-ftservfrom
nicolasCtd:remove_source_from_put_condition

Conversation

@nicolasCtd

Copy link
Copy Markdown
Collaborator

It should be possible to register an external "put" method regardless of the source file being transferred.

According to the current logic, the default "put" method must be used when:

  • cpipeline is not None
  • cpipeline.compress2rawftp(source) returns None.

However, compress2rawftp() does not actually use its input argument.

def compress2rawftp(self, local):
"""
Return the name of the rawftp's specialshell that can be used to
compress the *local* data. It might return None.
"""
return self._rawftp_shell

As a consequence, method.put_condition() only need cpipeline (and source can be replaced by any str value in the "put_condition" function).

@nicolasCtd
nicolasCtd requested a review from tlestang August 5, 2026 10:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant