Skip to content

Fixing error when launching Alex without private configs. - #122

Open
ticcky wants to merge 1 commit into
masterfrom
lz_private_config_fix
Open

Fixing error when launching Alex without private configs.#122
ticcky wants to merge 1 commit into
masterfrom
lz_private_config_fix

Conversation

@ticcky

@ticcky ticcky commented Feb 1, 2015

Copy link
Copy Markdown
Contributor

Adding an empty file that will prevent Alex from failing because of including private files from the main config that do not exist in case somebody is using Alex without the private repository.

@oplatek

oplatek commented Feb 2, 2015

Copy link
Copy Markdown
Member

@ticcky what will happen if you want to add the private git repository?
Will it mess the git index with the real secret default.cfg?
If yes, this is easy way how to expose the secret private/default.cfg by accidentally committing it to the public UFAL-DSG/alex repository

@ticcky

ticcky commented Feb 2, 2015

Copy link
Copy Markdown
Contributor Author

That's right Ondra. Thanks! I think the best thing would be actually to remove the include from the config file altogether, and actually have the include in the secret file but in reverse. What do you think?

@oplatek

oplatek commented Feb 2, 2015

Copy link
Copy Markdown
Member

Well, is it really necessary to include one into another or vise versa?
Why not to load the "secret" values explicitly by specifying the "private/default.cfg" in the command line arguments by "-c private/default.cfg"?

@ticcky

ticcky commented Feb 2, 2015

Copy link
Copy Markdown
Contributor Author

That is even better. I will discuss it with Filip.

@landscape-bot

Copy link
Copy Markdown

Code Health
Code quality remained the same when pulling ee7dc16 on UFAL-DSG:lz_private_config_fix into 0338af6 on UFAL-DSG:lz_private_config_fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants