A.1: Homepage banner VoiceOver reads TWOW as separate letters#2313
Open
Ishxn20 wants to merge 3 commits into
Open
A.1: Homepage banner VoiceOver reads TWOW as separate letters#2313Ishxn20 wants to merge 3 commits into
Ishxn20 wants to merge 3 commits into
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR improves banner accessibility by adjusting the Semantics.label used for the homepage notices banner so that screen readers spell out the acronym “TWOW” as “T W O W” (case-insensitive, whole-word match), and adds widget tests to validate the behavior.
Changes:
- Add a TWOW whole-word regex and a helper to transform the banner’s accessibility label to “T W O W”.
- Update the banner
Semanticslabel to use the transformed string. - Add widget tests covering the TWOW match, non-matching titles, and substring non-matches.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| lib/ui/notices/notices_card.dart | Spaces “TWOW” in the banner’s Semantics.label via a whole-word, case-insensitive replacement. |
| test/ui/notices/notices_card_test.dart | Adds widget tests asserting the semantics label transformation behavior. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+26
to
+27
| final semantics = tester.getSemantics(findBannerSemantics()); | ||
| expect(semantics.label, 'UC San Diego T W O W'); |
Comment on lines
+45
to
+46
| final semantics = tester.getSemantics(findBannerSemantics()); | ||
| expect(semantics.label, 'Welcome Week Schedule'); |
Comment on lines
+64
to
+65
| final semantics = tester.getSemantics(findBannerSemantics()); | ||
| expect(semantics.label, 'TWOWeek Kickoff'); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Screen readers now spell “TWOW” as separate letters on homepage banners.
Verification