Skip to content
This repository was archived by the owner on Jan 7, 2025. It is now read-only.

fixed regrade all bug if autograde job fails #70

Open
Searay-330 wants to merge 1 commit into
base: dev
Choose a base branch
from
Open

fixed regrade all bug if autograde job fails #70

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions app/controllers/assessment/autograde.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -108,6 +108,7 @@ def regradeAll

last_submissions = @submissions.latest


# Now regrade only the most recent submissions. Keep track of
# any handins that fail.
failed_jobs = 0
Expand All @@ -119,15 +120,16 @@ def regradeAll
redirect_to([@course, @assessment, :submissions]) && return
elsif job < 0 # autograding failed
failed_jobs += 1
failed_list += "#{@submission.filename}: autograding error.<br>"
failed_list += "#{submission.filename}: #{flash[:error]}.<br>"

@daviddob daviddob Jun 19, 2020

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What does this behavior look like? Is it necessary to have a flash inside of a message that will be itself flashed on line 132?

end
else
# abort submission.inspect
failed_jobs += 1
failed_list += "#{submission.filename}: not found or not readable.<br>"
failed_list += "NIL submission decteced.<br>"
end
end

flash[:error] = "Warning: Could not regrade #{failed_jobs} submission(s):<br>" + failed_list if failed_jobs > 0
flash[:error] = "Error: Could not regrade #{failed_jobs} submission(s):<br>" + failed_list if failed_jobs > 0

@daviddob daviddob Jun 19, 2020

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should likely still be a warning as it has regraded all other jobs successfully.


success_jobs = last_submissions.size - failed_jobs
if success_jobs > 0
Expand Down