Fix plan version history recording on sync and create

[Tyru5]

Summary

Plan History (Pro) looked broken because the main ingest path never wrote planVersions rows.

What was wrong

• cli.upsertPlan (daemon / POST /api/cli/sync) incremented plans.version but never inserted into planVersions
• Creates (publishPlan / upsertPlan) set version: 1 with no v1 snapshot, so the original content was not restorable after the first edit
• Web publishPlan updates always versioned (including no-ops) and labeled snapshots as cli_sync

What changed

• Added shared helpers in planVersioning.ts (recordPlanVersion, ensureBaselinePlanVersion, planContentChanged)
• Snapshot v1 on create (CLI sync + web publish)
• Write a cli_sync snapshot on every content-changing CLI upsert
• Editor / publish paths write editor snapshots; skip no-op republishes
• On first update of a plan with empty history, backfill the pre-change state so existing cloud rows can recover a baseline
• Restore uses the same helper

Test plan

• bun test packages/ee/convex/planVersioning.test.ts
• bunx tsc --noEmit -p packages/ee/convex/tsconfig.json
• bun run lint / bun run fmt:check
• Manual: sync a new plan via CLI → history shows v1; edit locally and sync again → v2 appears with CLI sync badge
• Manual: create/edit in cloud editor → versions labeled Edited; restore creates a new Restored version

  

[greptile-apps]

Confidence Score: 5/5

Safe to merge. The core versioning logic is correct across all write paths and the previous review gaps (no-op guard on CLI upsert, missing source label on backfill rows) are now addressed.

All three mutation paths (CLI upsert, web publish, editor save) correctly guard with planContentChanged, backfill a baseline for legacy rows, and write properly labeled snapshots. The diff algorithm refactor is pure logic extraction with no behavioral regressions. The only note is that the no-op early return in publishPlan skips patching non-content live fields, but this is a minor inconsistency with the CLI path rather than a data-loss path in normal usage.

packages/ee/convex/plans.ts — publishPlan's no-op branch returns without updating agent/format/filePath/workspace, unlike the CLI equivalent.

_{Reviews (3): Last reviewed commit: "feat: render git-style hunks in plan ver..." | Re-trigger Greptile}