fix: show desktop daemon origin info#168
Merged
Merged
Conversation
Render daemon registry info with launcher provenance, treat Electron utility workers as running when their parent is alive, and pass the worker marker through execArgv so it shows up in process listings. Add coverage for PID ownership, status output, and desktop daemon startup.
Contributor
Confidence Score: 5/5This PR is safe to merge. The changes are well-scoped, all three changed behaviors (status display, Electron utility process detection, orphan detection) are exercised by new or updated tests, and the execArgv pitfall is explicitly guarded in both code and tests. All modified paths have direct test coverage. The isElectronUtilityCommand check is correctly narrowed to the Node-specific sub-type rather than the broader Chromium utility type. The args-vs-execArgv decision is correct and verified by the fork-call assertion. No pre-existing injection or liveness issues are made worse by the changes. No files require special attention. Reviews (2): Last reviewed commit: "fix: harden desktop daemon ownership che..." | Re-trigger Greptile |
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
Drop invalid execArgv that would crash Node workers, narrow utility matching to NodeService, and honor injected PID liveness hooks. Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Render daemon registry info with launcher provenance, treat Electron utility workers as running when their parent is alive, and pass the worker marker through execArgv so it shows up in process listings. Add coverage for PID ownership, status output, and desktop daemon startup.