fix: use regex.source for pattern to handle regex flags correctly#108
Open
peekg wants to merge 1 commit into
Open
fix: use regex.source for pattern to handle regex flags correctly#108peekg wants to merge 1 commit into
peekg wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes regex pattern extraction to properly handle regex flags by using the
.sourceproperty instead of manually slicing the string representation.Problem
The previous implementation used
.toString().slice(1, -1)to extract the pattern from a regex, which incorrectly included flags in the output when they were present (e.g.,/^A$/uwould produce^A$/instead of^A$).Solution
Use the standard
.sourceproperty which returns only the pattern text without delimiters or flags.Changes
pattern.args.regex.toString().slice(1, -1)withpattern.args.regex.sourceTesting
Added test case verifying that
joi.string().regex(/^A$/u)correctly producespattern: '^A$'in the swagger output.