This repository was archived by the owner on Nov 15, 2022. It is now read-only.
.env entries override system environment vars#53
Open
zevaverbach wants to merge 2 commits into
Open
Conversation
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This would have saved me a few hours of frustration, and I imagine will do the same for anyone using this starter repo who already has Twilio-related env vars in their
.bashrc.The net effect is that env vars will be used as a fallback instead of the primary source of truth for the variables this repo's README encourages users to create. The documentation here, as it exists, doesn't consider the possibility that
.envmight get overridden by env vars. This PR fulfills that assumption by preventing it from ever happening.fixes #52