Skip to content

Error handing #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
lexiwooood wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Error handing #2

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 15 additions & 7 deletions api/app/main.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -114,21 +114,29 @@ def getOorU(walletAddress):

#This is an EtherScan API PRO Call, we need to replace with something else, currently using Current Price as Placeholder
#ethPriceAtTimeOfFirstMintResponse = getHistoricalEthPrice(startDate=earliestNFTInWalletTimeStamp.date(), currentDate=currentDate)
earliestDateString = str(earliestNFTInWalletTimeStamp.date().strftime("%d-%m-%Y"))
try:
earliestDateString = str(earliestNFTInWalletTimeStamp.date().strftime("%d-%m-%Y"))
except:
print("An exception occurred while trying to get earliestNFTInWalletTimeStamp")

@TueeNguyen TueeNguyen Jan 30, 2022

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you can also print the value of the earliestNFTInWalletTimeStamp variable. It can look like this I think

print(f'An exception occurred while trying to get earliestNFTInWalletTimeStamp, got {earliestNFTInWalletTimeStamp}')

ethPriceAtTimeOfFirstMintResponse = getHistoricalEthPrice(dateString = earliestDateString)
ethPriceAtTimeOfFirstMint = float(ethPriceAtTimeOfFirstMintResponse)
#float(ethPriceAtTimeOfFirstMintResponse['result']['ethusd'])

currentEthPriceResponse = getCurrentEthPrice()
currentEthPrice = float(currentEthPriceResponse['result']['ethusd'])

try:
currentEthPriceResponse = getCurrentEthPrice()
currentEthPrice = float(currentEthPriceResponse['result']['ethusd'])
except:
print("An exception occurred while trying to get the currrent eth price")

@TueeNguyen TueeNguyen Jan 30, 2022

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same with the previous comment

historicalEthRate = currentEthPrice - ethPriceAtTimeOfFirstMint / ethPriceAtTimeOfFirstMint
if performanceRate < historicalEthRate:
performanceClassification = "Underperformed"
value = "U"
else:
elif performanceRate > historicalEthRate:
performanceClassification = "Overperformed"
value = "O"
value = "O"
else:
print("Was not able to generate O/U ")



userMessage = \
f"We analyzed all ERC721 transacations for this wallet and found the seven day average price of your NFT's - the purchase price / the sum of the seven " \
Expand Down