feat: dollar tokens Phase 3 foundation (re-targeted to Development)#150
Merged
Conversation
…to swapSubmitSaga
Phase 3 foundation introduced a new top-level reducer 'dollarsSpend'. The RootStateSchema validator + store inline snapshot detected the new key and demanded a migration. Adds migration 247 (no-op seed), v247 test schema, bumps persistConfig.version to 247, and refreshes the rootState inline snapshot to include the new slice. Also adds an eslint-disable for an empty arrow inside a Promise constructor in the multi-quote hook test.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Re-opens Phase 3 foundation against Development. The original PR #149 was mistakenly stacked on top of
feat/integrate-usdc-usdm-usat-phase1(PR #148's branch) and got merged into that feature branch instead of Development, so the 11 Phase 3 commits never reached Development.PR #148 (Phase 1 + Phase 2) is already in Development as expected.
Same code as PR #149, same verification status. No changes needed; this is a re-target.
What this PR contains
New module
src/dollarsSpend/(foundation only - no UI integration):Auxiliary:
src/swap/useSwapQuote.ts- extractfetchSwapQuoteas a named export (lightweight price-discovery function)src/redux/reducersList.ts+src/redux/sagas.ts- register slice + sagasrc/redux/migrations.ts+src/redux/store.ts- migration 247 + persistConfig.version bumptest/RootStateSchema.json+test/schemas.ts- regenerated, v247Schema addedknip.ts- ignore dollarsSpend barrel until Phase 3.2 UI consumes itVerification (verified locally before push)
yarn build:ts- passyarn lint- passyarn test- 374 suites pass, 4029 tests pass, 96 snapshots pass, 0 failuresyarn knip --no-gitignore- dollarsSpend barrel ignoredKnown follow-ups for Phase 3.2 (UI integration, separate PR)
collapseDollarspropdollarsSpend.*)preparedTransactions: []because the lightfetchSwapQuotedoes not build them; Phase 3.2 must either (a) extend fetchSwapQuote to call prepareSwapTransactions per step, or (b) have the UI use the fulluseSwapQuoteto prebuild quotes including preparedTransactions for each step and pass them via the action payload.