[codex] Update gpui to latest upstream#2
Draft
Tryanks wants to merge 1 commit into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
gpuigit dependency lock frome30720a781ad5e4bee9ab6e5c9f228baffef466cto upstreammainat2b2536de0f9de56da870fbff320412178756245e.gpui-trayfrom0.1.0to0.1.1.objc2dependencies to the0.6/0.3generation so the tray implementation continues to compile with the latest dependency graph.Why
The latest GPUI update changed application menu and window-close callback APIs, and the broader dependency update made the previous broad
objc2 = "0"constraints resolve to an older incompatible Objective-C crate generation.Validation
cargo check --all-targetscargo fmt --checkcargo testAdditional cross-target checks were attempted for
x86_64-unknown-linux-gnuandx86_64-pc-windows-gnu, but this macOS environment is missing the required cross C/C++ toolchains/pkg-config sysroots (x86_64-linux-gnu-gcc/g++,x86_64-w64-mingw32-gcc, fontconfig sysroot), so those did not complete.