Allow hs2019 algorithm in signing and verifying (rebased, improved, tests, squashed)#116
Open
ashpieboop wants to merge 3 commits into
Open
Allow hs2019 algorithm in signing and verifying (rebased, improved, tests, squashed)#116ashpieboop wants to merge 3 commits into
ashpieboop wants to merge 3 commits into
Conversation
add assert for new option
Fix lint issues Add missing parameter validation to verifySignature() g g
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #106
From #105:
I removed the manual algorithm override from original PR as it's supposed to be determined by the key metadata (aka public key type) for hs2019.
Also, hash algo is supposed to be sha512 so it is forced in
validateAlgorithm().