Refactor: deduplicate isCashAddr into shared btc.HasCashAddrPrefix#2
Draft
Copilot wants to merge 2 commits into
Draft
Refactor: deduplicate isCashAddr into shared btc.HasCashAddrPrefix#2Copilot wants to merge 2 commits into
isCashAddr into shared btc.HasCashAddrPrefix#2Copilot wants to merge 2 commits into
Conversation
…ix utility Co-authored-by: Trinaj037 <207996474+Trinaj037@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Refactor duplicated code for better maintainability
Refactor: deduplicate Mar 2, 2026
isCashAddr into shared btc.HasCashAddrPrefix
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
isCashAddrfunction was copy-pasted identically into bothbchain/coins/bchandbchain/coins/ecash, differing only in the package-level prefix constants each referenced.Changes
bchain/coins/btc/bitcoinlikeparser.go— Added shared utilityHasCashAddrPrefix(addr string, prefixes ...string) bool; bothbchandecashalready import this packagebchain/coins/bch/bcashparser.go— RemovedisCashAddr, updated call site tobtc.HasCashAddrPrefix(address, MainNetPrefix, TestNetPrefix, RegTestPrefix)bchain/coins/ecash/ecashparser.go— Same as aboveWarning
Firewall rules blocked me from connecting to one or more addresses (expand for details)
I tried to connect to the following addresses, but was blocked by firewall rules:
dl.google.com/usr/bin/wget wget REDACTED(dns block)If you need me to access, download, or install something from one of these locations, you can either:
🔒 GitHub Advanced Security automatically protects Copilot coding agent pull requests. You can protect all pull requests by enabling Advanced Security for your repositories. Learn more about Advanced Security.