MOB-2426: Bug fixed and enhancements by shachartransmit · Pull Request #11 · TransmitSecurity/react-native-ts-accountprotection

shachartransmit · 2026-04-03T18:06:20Z

Version 3.0.0 (Not raised in project yet)

SDK Updates

Added getSessionToken API
Added clearUser API
Added support for init configuration on iOS to enable location (Android not applicable)
Added support for enabling location in Trigger Action
Implemented logPageLoad(_ pageName: String)
Made baseUrl a required parameter in initializeSDK
Updated the Trigger Action API
Added support for userId in initialize parameters, including options
Added support for customAttributes in Trigger Action
Renamed setUser to setAuthenticatedUser

…le optional options parameter in Android triggerAction

Copilot

Pull request overview

Updates the React Native wrapper to align with TransmitSecurity Account Protection SDK 3.0.0, expanding the public JS API (session token, page-load logging, richer trigger actions) and updating the example + docs accordingly.

Changes:

Upgraded native dependencies to AccountProtection 3.0.0 (iOS CocoaPods + Android Gradle).
Expanded JS/native bridge APIs: initializeIOS(...) w/ config + userId, setAuthenticatedUser(...), enhanced triggerAction(...), plus getSessionToken() and logPageLoad(...).
Updated example app and documentation to reflect new initialization requirements (/risk-collect/) and behavioral tracking guidance (testID).

Reviewed changes

Copilot reviewed 19 out of 20 changed files in this pull request and generated 11 comments.

Show a summary per file

File	Description
src/index.tsx	Adds new TS types/enums and updates exported JS API signatures (init/config, user, triggerAction, session token, page load).
react-native-ts-accountprotection.podspec	Bumps iOS native dependency `AccountProtection` to 3.0.0.
ios/TsAccountprotection.swift	Implements updated iOS bridge methods and new APIs (session token, page-load logging, location config, claimed user id type).
ios/TsAccountprotection.mm	Updates Objective-C extern declarations to match new Swift bridge signatures.
android/src/main/java/com/tsaccountprotection/TsAccountprotectionModule.kt	Updates Android bridge methods to new APIs and adds session token/page-load/location/customAttributes support.
android/build.gradle	Pins Android SDK dependency to `com.ts.sdk:accountprotection:3.0.0`.
android/src/main/res/values/strings.xml	Removes placeholder credential strings from the library resources.
example/src/App.tsx	Updates example usage to new init/user/session/triggerAction APIs and adds extra demo data.
example/src/screens/login.tsx	Logs page load on mount; adds `testID` to login button.
example/src/screens/authenticated-user.tsx	Logs page load on mount; tweaks default demo values.
example/src/config.ts	Updates example baseUrl to include `/risk-collect/` and fixes trailing semicolon.
example/android/app/build.gradle	Updates example Android dependency to 3.0.0.
example/android/app/src/main/java/com/tsaccountprotectionexample/MainApplication.kt	Keeps Android SDK init in `onCreate` (minor formatting changes).
example/android/app/src/main/res/values/strings.xml	Adds example app credential/baseUrl strings with `/risk-collect/`.
example/ios/TransmitSecurity.plist	Updates example plist baseUrl to `/risk-collect/` and sets a clientId placeholder.
example/ios/Podfile.lock	Updates pods lockfile to AccountProtection 3.0.0 and wrapper version.
example/ios/TsAccountprotectionExample.xcodeproj/project.pbxproj	Updates CocoaPods integration references/build phases for the example project.
README.md	Updates integration docs for 3.0.0 APIs/config, adds behavioral tracking guidance and new API docs.
RELEASE_NOTES.md	Adds a 3.0.0 release entry summarizing API changes and breaking changes.
MIGRATION_0.1.9-0.2.0.md	Extends migration guide with new APIs and initialization/action option changes.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot · 2026-04-16T14:08:15Z

+
+export interface TSLocationConfig {
+  mode: 'disabled' | 'default' | 'forceCurrent' | 'forceLastKnown' | 'lastKnown';
+  validFor?: number | null | undefined; // return last-known only if it is not older than `validFor` minutes.


validFor?: number | null | undefined is redundant because an optional property already covers undefined. Prefer validFor?: number | null (or just validFor?: number) to keep the public type surface simpler.

Suggested change

validFor?: number | null | undefined; // return last-known only if it is not older than `validFor` minutes.

validFor?: number | null; // return last-known only if it is not older than `validFor` minutes.

Copilot · 2026-04-16T14:08:15Z

@@ -4,12 +4,17 @@ import { SafeAreaView, Keyboard, Alert, Platform } from 'react-native';

 import { 
  initializeSDKIOS,


initializeSDKIOS is imported but not used (the only reference is commented out). With noUnusedLocals enabled in the repo tsconfig, this will fail yarn typecheck; remove the import or use it (e.g., behind a platform/feature flag).

Suggested change

initializeSDKIOS,

Copilot · 2026-04-16T14:08:15Z

+  func initializeIOS(
+    _ clientId: String,
+    baseUrl: String,
+    configuration: [String: Any]?,
+    userId: String?,
+    resolve: @escaping RCTPromiseResolveBlock,
+    reject: @escaping RCTPromiseRejectBlock) -> Void {
+      runBlockOnMain {
+        var nativeConfiguration: AccountProtection.TSInitSDKConfiguration?
+
+        if let config = configuration {
+          let enableTrackingBehavioralData = config["enableTrackingBehavioralData"] as? Bool
+          let enableLocationEvents = config["enableLocationEvents"] as? Bool
+
+          nativeConfiguration = TSInitSDKConfiguration(
+            enableTrackingBehavioralData: enableTrackingBehavioralData ?? true,
+            enableLocationEvents: enableLocationEvents ?? false
+          )
        }
+
+        TSAccountProtection.initialize(baseUrl: baseUrl, clientId: clientId, userId: userId, configuration: nativeConfiguration)
+
+        resolve(true)


initializeIOS no longer validates baseUrl. Since baseUrl is now required (and docs say it must include /risk-collect/), it would be better to reject early when baseUrl is empty/invalid to avoid confusing downstream SDK failures.

Copilot · 2026-04-16T14:08:16Z

+**Available TSClaimedUserIdType values:**
+- `TSClaimedUserIdType.email`
+- `TSClaimedUserIdType.username`
+- `TSClaimedUserIdType.phoneNumber`
+- `TSClaimedUserIdType.accountId`
+- `TSClaimedUserIdType.ssn`
+- `TSClaimedUserIdType.nationalId`
+- `TSClaimedUserIdType.passportNumber`
+- `TSClaimedUserIdType.driversLicenseNumber`
+- `TSClaimedUserIdType.other`
+const options = {
+  claimUserId: "user123", // @deprecated - still works for backward compatibility
+  claimedUserId: "user@example.com", // NEW - preferred field
+  claimedUserIdType: TSClaimedUserIdType.email, // NEW - specifies identifier type
+  correlationId: "correlation-123"
+}
+```


There is a Markdown formatting issue: after listing available TSClaimedUserIdType values, a const options = { ... } snippet starts without an opening code fence, and the closing fence appears later. This breaks rendering; wrap that snippet in a proper fenced code block.

Copilot · 2026-04-16T14:08:16Z

+**Option 1: Basic initialization (uses TransmitSecurity.plist configuration)**
 ```js
 import { initializeSDKIOS } from 'react-native-ts-accountprotection';

 componentDidMount(): void {
-    // Setup the module as soon your component is ready
    await initializeSDKIOS();
 }
 ```

+**Option 2: Advanced initialization with custom parameters**
+```js
+import { initializeIOS } from 'react-native-ts-accountprotection';
+
+componentDidMount(): void {
+    await initializeIOS(
+        "your-client-id", 
+        "https://api.transmitsecurity.io/risk-collect/", // ⚠️ CRITICAL: Must include /risk-collect/ postfix


Both iOS initialization examples show await inside componentDidMount(): void { ... }, which is not valid JS/TS (the method must be async, or use a promise chain / useEffect). Please fix the snippets so developers can copy/paste without syntax errors.

Copilot · 2026-04-16T14:08:17Z

  @ReactMethod
-  fun setUserId(userId: String) {
+  fun setAuthenticatedUser(userId: String, options: ReadableMap?, promise: Promise) {
    if(reactContext.currentActivity != null) {
-      Log.d("TS", ">>> setUserId userId=$userId")
-      TSAccountProtection.setUserID(userId)
-      reactContext.resources.getString(R.string.transmit_security_client_id)
+      val optionsMap = convertCustomAttributes(options)
+      TSAccountProtection.setAuthenticatedUser(userId, optionsMap)
+      promise.resolve(true)
+    } else {
+      promise.reject("error", "Activity not available")
    }
  }


setAuthenticatedUser forwards userId directly to the native SDK without any validation. iOS rejects empty userId; for consistency (and to avoid passing an invalid identifier to the SDK), consider rejecting when userId.isBlank() (or at least isEmpty()).

Copilot · 2026-04-16T14:08:17Z

+  @objc(setAuthenticatedUser:options:withResolver:withRejecter:)
+  func setAuthenticatedUser(userId: String, options: [String: Any]? = nil, resolve: @escaping RCTPromiseResolveBlock, reject: @escaping RCTPromiseRejectBlock) {
+    guard !userId.isEmpty else {
+      reject("Invalid params provided to setAuthenticatedUser", nil, nil)


In setAuthenticatedUser, the promise reject "code" is currently a full sentence (and the message is nil). React Native consumers often branch on the error code; please use a stable identifier-style code (e.g., invalid_params) and pass the human-readable text as the message.

Suggested change

reject("Invalid params provided to setAuthenticatedUser", nil, nil)

reject("invalid_params", "Invalid params provided to setAuthenticatedUser", nil)

Copilot · 2026-04-16T14:08:17Z

+        try TSAccountProtection.logPageLoad(pageName)
+        resolve(true)
+      } catch {
+        reject("logPageLoad Error", error.localizedDescription, nil)


In logPageLoad, the reject code contains a space ("logPageLoad Error"). To keep error handling consistent and machine-friendly, use a stable code without spaces (and put the descriptive text in the message).

Suggested change

reject("logPageLoad Error", error.localizedDescription, nil)

reject("logPageLoadError", error.localizedDescription, nil)

Copilot · 2026-04-16T14:08:17Z

+// Initialize with specific parameters and optional userId
+await initializeIOS(
+  "your-client-id",
+  "https://api.transmitsecurity.io", 


The migration guide's advanced initializeIOS example uses "https://api.transmitsecurity.io" without the required /risk-collect/ postfix. This conflicts with the README/release notes in this PR and will lead to a non-working integration; update the example URL accordingly.

Suggested change

"https://api.transmitsecurity.io",

"https://api.transmitsecurity.io/risk-collect/",

Copilot · 2026-04-16T14:08:18Z

+- **Renamed `setUser()` to `setAuthenticatedUser()`**: Method renamed for better clarity and consistency
+
+### 🛠️ Configuration Enhancements
+- **iOS Location Support**: Added configuration option to enable location data collection during SDK initialization
+- **Location in Actions**: Trigger Action now supports location configuration with modes: `disabled`, `default`, `forceCurrent`, `forceLastKnown`, `lastKnown`
+- **Custom Attributes**: Enhanced event tracking with support for custom attributes in trigger actions
+- **Behavioral Data Collection**: To collect behavioral data from UI elements, developers must add `testID` attributes to trackable elements (buttons, inputs, etc.)
+
+### ⚠️ Breaking Changes
+- **`baseUrl` is now required** in `initializeIOS()` method
+- **`setUser()` renamed to `setAuthenticatedUser()`** - update your method calls
+- **⚠️ CRITICAL: baseUrl must include `/risk-collect/` postfix** - e.g., `https://api.transmitsecurity.io/risk-collect/` (server connection will fail without this)


Release notes mention renaming setUser() to setAuthenticatedUser(), but the public JS API in this repo was setUserId(...) (and the native Android method was setUserID). Please update the release notes/breaking changes bullets to reference the correct prior API name to avoid confusion.

shachartransmit added 20 commits March 16, 2026 12:48

MOB-2426 Implemented clearUser and improve iOS/Android consistency

c79014c

MOB-242 fixed issue with clear user in example

da929b1

MOB-2426 Implemented getSessionToken

20f3bba

MOB-2426 implemented trigger action location options on ios

c899279

MOB-2426 implemented trigger action location options on android

36e3835

MOB-2426 implemented init location config on ios

cc8f6f6

MOB-2426 implemented logPageLoad API

937e020

MOB-2426 added testId to some elements

c27ffba

MOB-2426 Updated dependency source for testing

5ac7032

MOB-2426 refactor method to setAuthenticatedUser

cfdcd6f

MOB-2426 added support for options param to setAuthenticatedUser

406e26a

MOB-2426 added support for Trigger Action API enum Changes

d82fbfc

MOB-2426 Cleaned iOS implementation

bc26f1a

MOB-2426 added support for userId in initializeIOS

40af7a9

MOB-2426 Added support for customAttributes in Trigger Action

8daf319

MOB-2426 fixed Android compile issues

19ffc74

MOB-2426 Added test params to example app

fe0e90f

MOB-2426 make baseUrl required in initializeIOS type definition, hand…

a6d0051

…le optional options parameter in Android triggerAction

MOB-2426 Fixed Cursor code review comments

895d447

MOB-2426 Fixed Cursor second code review comments

8c4e54b

shachartransmit commented Apr 3, 2026

View reviewed changes

Comment thread android/build.gradle Outdated

shachartransmit commented Apr 3, 2026

View reviewed changes

Comment thread android/build.gradle Outdated

shachartransmit commented Apr 3, 2026

View reviewed changes

Comment thread example/src/App.tsx Outdated

shachartransmit added 7 commits April 6, 2026 14:13

MOB-2426 Updated release notes

998c8aa

MOB-2426 Updated README user guide

bf4080f

MOB-2426 Updated documentation with testId reference

3ea3b0c

MOB-2426 Added /risk-collect/ to baseUrl

f6557e1

MOB-2426 Added documentation for /risk-collect/ to baseUrl

2866ed8

2426 Updated to ios native 3.0.0 and tested

61e2b60

2426 Updated to Android native 3.0.0 and tested

a1dca0c

shachartransmit requested a review from Copilot April 16, 2026 13:59

Copilot started reviewing on behalf of shachartransmit April 16, 2026 13:59 View session

Copilot AI reviewed Apr 16, 2026

View reviewed changes

shachartransmit requested review from asaftransmitsecurity and igorbabitski April 16, 2026 14:20

igorbabitski approved these changes Apr 16, 2026

View reviewed changes

2426 Using weak self in TSAccountProtection.getSessionToken

d0f74c8

asaftransmitsecurity approved these changes Apr 16, 2026

View reviewed changes

shachartransmit merged commit 3284b06 into main Apr 16, 2026
3 of 5 checks passed

	validFor?: number \| null \| undefined; // return last-known only if it is not older than `validFor` minutes.
	validFor?: number \| null; // return last-known only if it is not older than `validFor` minutes.

		@@ -4,12 +4,17 @@ import { SafeAreaView, Keyboard, Alert, Platform } from 'react-native';

		import {
		initializeSDKIOS,

	reject("Invalid params provided to setAuthenticatedUser", nil, nil)
	reject("invalid_params", "Invalid params provided to setAuthenticatedUser", nil)

	reject("logPageLoad Error", error.localizedDescription, nil)
	reject("logPageLoadError", error.localizedDescription, nil)

	"https://api.transmitsecurity.io",
	"https://api.transmitsecurity.io/risk-collect/",

Uh oh!

Conversation

shachartransmit commented Apr 3, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Version 3.0.0 (Not raised in project yet)

SDK Updates

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Copilot AI Apr 16, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Apr 16, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Apr 16, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Apr 16, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Apr 16, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Apr 16, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Apr 16, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Apr 16, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Apr 16, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Apr 16, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

shachartransmit commented Apr 3, 2026 •

edited

Loading