初期画面のPull to Refresh対象を路線リストに限定した変更をリバートして元のスクロール挙動に戻す#6416
Merged
Conversation
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Gu76E8vDn9ZheWEpmQj6Db
Contributor
📝 WalkthroughWalkthroughSelectLineScreenのプリセットをScrollView内へ移動し、リスト余白とローディング表示を更新しました。関連するローディング状態テストの期待値も変更されています。 ChangesSelectLineScreen表示フロー
Estimated code review effort: 2 (Simple) | ~10 minutes Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
Contributor
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@src/screens/SelectLineScreen.tsx`:
- Around line 46-51: Remove paddingHorizontal from the listContainerStyle
definition in SelectLineScreen, keeping the root SafeAreaView horizontal padding
and existing list bottom padding unchanged.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: 0d1f5c7c-a4cb-4c5a-9ee0-0b069a48819f
📒 Files selected for processing (2)
src/screens/SelectLineScreen.render.test.tsxsrc/screens/SelectLineScreen.tsx
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
概要
初期画面の Pull to Refresh 対象を路線リストに限定した変更(#6412)を差し戻し、
SelectLineScreenを変更前の状態へ復元します。差戻しの理由: 元々の画面設計が Pull to Refresh を前提としておらず、「一部分(路線リスト)だけを PTR 対象にする」にはデザイン(構造)の変更が必要になる可能性が高いと判断したため。一旦挙動を元に戻し、設計方針は別途検討します。
変更の種類
変更内容
SelectLineScreen.tsx/SelectLineScreen.render.test.tsxを変更前と同一内容へ復元progressViewOffset/SafeAreaView構成も復元)テスト
npm run lintが通ることnpm testが通ることnpm run typecheckが通ること関連Issue
スクリーンショット(任意)
Generated by Claude Code
Summary by CodeRabbit
新機能
改善