Android向けE2Eテスト準備#4368
Conversation
|
Warning Rate limit exceeded@TinyKitten has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 9 minutes and 47 seconds before requesting another review. ⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. 📒 Files selected for processing (1)
""" Walkthrough朕が命ずる、新たなるGitHub Actionsワークフロー「Android E2E」を制定せり。此の仕組みは、プルリクエスト時に発動し、Ubuntu環境にてAndroidアプリのビルド、テスト、及び各種秘密情報の復元、成果物の保存を自動的に執行するものなり。 Changes
Sequence Diagram(s)sequenceDiagram
participant GitHub Actions
participant Ubuntu Runner
participant Secrets Store
participant Metro Bundler
participant Android Emulator
participant Maestro
GitHub Actions->>Ubuntu Runner: ワークフロー開始
Ubuntu Runner->>Ubuntu Runner: リポジトリ・サブモジュール取得
Ubuntu Runner->>Ubuntu Runner: pnpm, Node.js, Javaセットアップ
Ubuntu Runner->>Secrets Store: 秘密ファイル復元
Ubuntu Runner->>Ubuntu Runner: Maestroインストール
Ubuntu Runner->>Ubuntu Runner: Android SDK/Emulatorセットアップ
Ubuntu Runner->>Metro Bundler: Metro起動
Ubuntu Runner->>Ubuntu Runner: アプリビルド・インストール
Ubuntu Runner->>Android Emulator: アプリ起動
Ubuntu Runner->>Maestro: テスト実行
Maestro->>Ubuntu Runner: テスト結果・スクリーンショット生成
Ubuntu Runner->>GitHub Actions: 成果物アップロード
Ubuntu Runner->>Ubuntu Runner: Metro/プロセス終了・クリーンアップ
Possibly related PRs
Suggested labels
Poem
🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 3
🧹 Nitpick comments (3)
.github/workflows/android_e2e.yml (3)
60-65: 細事なれど：環境変数の重複、削ぎ落とせ
run:行で${{ secrets.RELEASE_KEYSTORE }}を直接参照しており、env:に同名変数を再宣言する理由は薄い。冗長を斬り捨てて簡潔を保て。
78-133: 朕の進言：ビルドとテストの冗長ロギングを強化せよ
・pnpm run android失敗時、Gradle の詳細ログを出力しなければ原因究明は困難。--stacktrace --info等を付与し、失敗時にはcatでmetro.log以外のログも収集せよ。
・アプリ起動待機は固定 15 秒より、adb shell pidof <package>等で実際の起動をポーリングする方が堅牢。
17-18: 末端の綻びも見逃すな：行末空白と終端改行の整理
YAMLlint が行末空白と EOF 改行欠落を訴えておる。機能に直接影響はせぬが、CI の美観を保つため掃除しておくが吉。Also applies to: 85-85, 90-90, 107-107, 111-111, 117-117, 121-121, 128-128, 161-161
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
.github/workflows/android_e2e.yml(1 hunks)
🧰 Additional context used
🧠 Learnings (1)
📓 Common learnings
Learnt from: TinyKitten
PR: TrainLCD/MobileApp#4249
File: __tests__/hooks/useTelemetrySender.enabled.test.tsx:54-68
Timestamp: 2025-05-07T23:04:31.413Z
Learning: TinyKitten is working on implementing a queue for movement logs in the TrainLCD mobile app, but realized the implementation differed from their original intention.
🪛 YAMLlint (1.37.1)
.github/workflows/android_e2e.yml
[error] 18-18: trailing spaces
(trailing-spaces)
[error] 85-85: trailing spaces
(trailing-spaces)
[error] 90-90: trailing spaces
(trailing-spaces)
[error] 107-107: trailing spaces
(trailing-spaces)
[error] 111-111: trailing spaces
(trailing-spaces)
[error] 117-117: trailing spaces
(trailing-spaces)
[error] 121-121: trailing spaces
(trailing-spaces)
[error] 128-128: trailing spaces
(trailing-spaces)
[error] 161-161: no new line character at the end of file
(new-line-at-end-of-file)
| shell: bash | ||
| run: echo "$PLAY_STORE_CREDENTIALS_JSON" | tr -d '\r' > ./android/play-store-credentials.json | ||
| env: | ||
| PLAY_STORE_CREDENTIALS_JSON: ${{ secrets.PLAY_STORE_CREDENTIALS_JSON }} |
There was a problem hiding this comment.
🛠️ Refactor suggestion
朕の勅令：こちらも城壁を築け
android 直下に play-store-credentials.json を置く前に、ディレクトリの存在確認を怠るべからず。同様に mkdir -p ./android を加えよ。
🤖 Prompt for AI Agents
In .github/workflows/android_e2e.yml around lines 55 to 58, before writing the
play-store-credentials.json file to the ./android directory, add a command to
ensure the ./android directory exists by running mkdir -p ./android. This
prevents errors if the directory is missing.
TinyKitten
force-pushed
the
feature/e2e-ci
branch
from
89417b4 to
79ec287
Compare
There was a problem hiding this comment.
Actionable comments posted: 0
♻️ Duplicate comments (3)
.github/workflows/android_e2e.yml (3)
34-38: 朕の勅命：Java 21は早計、17へ降格せよ
再三諫言した通り、Android Gradle Plugin は 21 を正式に支援せず、ビルドが瓦解する恐れ大。LTS である 17 に戻すが賢明なり。- java-version: "21" + java-version: "17"
48-52: 朕の勅令：城壁を築かずして文書を投じるべからず
./android/app/src/devが無ければ秘宝（google-services.json）は宙に散る。先に道を拓き、失態を避けよ。- run: echo "$GOOGLE_SERVICES_JSON" | tr -d '\r' > ./android/app/src/dev/google-services.json + run: | + mkdir -p ./android/app/src/dev + echo "$GOOGLE_SERVICES_JSON" | tr -d '\r' > ./android/app/src/dev/google-services.json
54-58: 朕の勅令：陣地無き処に秘鍵を置くな
./android直下が存在せねば play-store-credentials.json は書き込めぬ。己が領土を整えよ。- run: echo "$PLAY_STORE_CREDENTIALS_JSON" | tr -d '\r' > ./android/play-store-credentials.json + run: | + mkdir -p ./android + echo "$PLAY_STORE_CREDENTIALS_JSON" | tr -d '\r' > ./android/play-store-credentials.json
🧹 Nitpick comments (2)
.github/workflows/android_e2e.yml (2)
39-41: 朕の小言：依存の決定版を固定せよ
再現性を確保するためpnpm install --frozen-lockfileを用い、lockfile 逸脱を弾くが良い。- - name: Install dependencies - run: pnpm i + - name: Install dependencies + run: pnpm install --frozen-lockfile
17-18: 朕の潔癖：余計な空白は斬り捨てよ
末尾の空白と終端改行欠如は lint で吊し上げられる。美しき律を守るが道。Also applies to: 85-85, 90-90, 107-107, 111-111, 114-114, 118-118, 122-122, 127-127, 161-161, 165-165
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
.github/workflows/android_e2e.yml(1 hunks)
🧰 Additional context used
🧠 Learnings (2)
📓 Common learnings
Learnt from: TinyKitten
PR: TrainLCD/MobileApp#4249
File: __tests__/hooks/useTelemetrySender.enabled.test.tsx:54-68
Timestamp: 2025-05-07T23:04:31.413Z
Learning: TinyKitten is working on implementing a queue for movement logs in the TrainLCD mobile app, but realized the implementation differed from their original intention.
.github/workflows/android_e2e.yml (1)
Learnt from: TinyKitten
PR: TrainLCD/MobileApp#3947
File: ios/ci_scripts/ci_pre_xcodebuild.sh:2-3
Timestamp: 2024-12-15T00:35:52.018Z
Learning: `ios/ci_scripts/ci_pre_xcodebuild.sh` スクリプトでは、Prod ディレクトリを作成する必要はありません。
🪛 YAMLlint (1.37.1)
.github/workflows/android_e2e.yml
[error] 18-18: trailing spaces
(trailing-spaces)
[error] 85-85: trailing spaces
(trailing-spaces)
[error] 90-90: trailing spaces
(trailing-spaces)
[error] 107-107: trailing spaces
(trailing-spaces)
[error] 111-111: trailing spaces
(trailing-spaces)
[error] 114-114: trailing spaces
(trailing-spaces)
[error] 118-118: trailing spaces
(trailing-spaces)
[error] 122-122: trailing spaces
(trailing-spaces)
[error] 127-127: trailing spaces
(trailing-spaces)
[error] 161-161: trailing spaces
(trailing-spaces)
[error] 165-165: trailing spaces
(trailing-spaces)
[error] 167-167: no new line character at the end of file
(new-line-at-end-of-file)
There was a problem hiding this comment.
Actionable comments posted: 1
♻️ Duplicate comments (3)
.github/workflows/android_e2e.yml (3)
34-38: 朕の勅命：Java 21を退かせ、LTSたる17を奉れ
現行 Android Gradle Plugin は Java 21 を正式に支援せず、ビルド崩壊の恐れ大。安定を期すならば LTS の 17 を用いるが良い。- java-version: "21" + java-version: "17"
48-52: 朕の勅令：陣地無きままに軍旗を立てるでない
./android/app/src/devが無ければgoogle-services.jsonの書き込みは空転する。先に道を拓き、しかる後に書き込むのだ。-run: echo "$GOOGLE_SERVICES_JSON" | tr -d '\r' > ./android/app/src/dev/google-services.json +run: | + mkdir -p ./android/app/src/dev + echo "$GOOGLE_SERVICES_JSON" | tr -d '\r' > ./android/app/src/dev/google-services.json
54-58: 朕の勅令：城壁を築かずして勅書を納めるべからず
./androidが欠如すればplay-store-credentials.jsonは宙に消える。ディレクトリを創りてより格納せよ。-run: echo "$PLAY_STORE_CREDENTIALS_JSON" | tr -d '\r' > ./android/play-store-credentials.json +run: | + mkdir -p ./android + echo "$PLAY_STORE_CREDENTIALS_JSON" | tr -d '\r' > ./android/play-store-credentials.json
🧹 Nitpick comments (1)
.github/workflows/android_e2e.yml (1)
18-18: 朕の小言：末端の余白を削ぎ、書を美しく整えよ
行末の余計な空白と終端の改行欠落が YAMLlint の叱責を招いておる。些事なれど礼節を欠くは武門の恥、清めるが吉。Also applies to: 93-115, 119-129, 134-134, 168-168, 172-174
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
.github/workflows/android_e2e.yml(1 hunks)
🧰 Additional context used
🧠 Learnings (2)
📓 Common learnings
Learnt from: TinyKitten
PR: TrainLCD/MobileApp#4249
File: __tests__/hooks/useTelemetrySender.enabled.test.tsx:54-68
Timestamp: 2025-05-07T23:04:31.413Z
Learning: TinyKitten is working on implementing a queue for movement logs in the TrainLCD mobile app, but realized the implementation differed from their original intention.
.github/workflows/android_e2e.yml (1)
Learnt from: TinyKitten
PR: TrainLCD/MobileApp#3947
File: ios/ci_scripts/ci_pre_xcodebuild.sh:2-3
Timestamp: 2024-12-15T00:35:52.018Z
Learning: `ios/ci_scripts/ci_pre_xcodebuild.sh` スクリプトでは、Prod ディレクトリを作成する必要はありません。
🪛 YAMLlint (1.37.1)
.github/workflows/android_e2e.yml
[error] 18-18: trailing spaces
(trailing-spaces)
[error] 93-93: trailing spaces
(trailing-spaces)
[error] 98-98: trailing spaces
(trailing-spaces)
[error] 115-115: trailing spaces
(trailing-spaces)
[error] 119-119: trailing spaces
(trailing-spaces)
[error] 121-121: trailing spaces
(trailing-spaces)
[error] 125-125: trailing spaces
(trailing-spaces)
[error] 129-129: trailing spaces
(trailing-spaces)
[error] 134-134: trailing spaces
(trailing-spaces)
[error] 168-168: trailing spaces
(trailing-spaces)
[error] 172-172: trailing spaces
(trailing-spaces)
[error] 174-174: no new line character at the end of file
(new-line-at-end-of-file)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
- GitHub Check: e2e
There was a problem hiding this comment.
Actionable comments posted: 0
♻️ Duplicate comments (3)
.github/workflows/android_e2e.yml (3)
34-37: 朕の勅命：Java 17を用いて安定を得よ
現行 AGP は 21 を正式に支援せず、ビルド失敗の恐れ大。LTS たる 17 に降格せよ。- java-version: "21" + java-version: "17"
48-52: 朕の警告：書き込む前に路を拓け（ディレクトリ作成を忘るな）
./android/app/src/devが存在せねば秘密鍵の復元は即死。mkdir -pを挿入し、道を整えよ。-run: echo "$GOOGLE_SERVICES_JSON" | tr -d '\r' > ./android/app/src/dev/google-services.json +run: | + mkdir -p ./android/app/src/dev + echo "$GOOGLE_SERVICES_JSON" | tr -d '\r' > ./android/app/src/dev/google-services.json
54-58: 朕の戒め：城壁を築きてから証書を置け
./androidが無ければ書き込みは叶わず。以下の如く防壁を築くべし。-run: echo "$PLAY_STORE_CREDENTIALS_JSON" | tr -d '\r' > ./android/play-store-credentials.json +run: | + mkdir -p ./android + echo "$PLAY_STORE_CREDENTIALS_JSON" | tr -d '\r' > ./android/play-store-credentials.json
🧹 Nitpick comments (1)
.github/workflows/android_e2e.yml (1)
17-18: 朕の小言：末尾の余白を掃き清めよ
YAMLlint が多数の trailing space を嘆いておる。動作へ影響は薄いが、臣下の品格として除去せよ。Also applies to: 93-98, 115-116, 119-121, 125-126, 129-134, 168-172
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
.github/workflows/android_e2e.yml(1 hunks)
🧰 Additional context used
🧠 Learnings (2)
📓 Common learnings
Learnt from: TinyKitten
PR: TrainLCD/MobileApp#4249
File: __tests__/hooks/useTelemetrySender.enabled.test.tsx:54-68
Timestamp: 2025-05-07T23:04:31.413Z
Learning: TinyKitten is working on implementing a queue for movement logs in the TrainLCD mobile app, but realized the implementation differed from their original intention.
.github/workflows/android_e2e.yml (1)
Learnt from: TinyKitten
PR: TrainLCD/MobileApp#3947
File: ios/ci_scripts/ci_pre_xcodebuild.sh:2-3
Timestamp: 2024-12-15T00:35:52.018Z
Learning: `ios/ci_scripts/ci_pre_xcodebuild.sh` スクリプトでは、Prod ディレクトリを作成する必要はありません。
🪛 YAMLlint (1.37.1)
.github/workflows/android_e2e.yml
[error] 18-18: trailing spaces
(trailing-spaces)
[error] 93-93: trailing spaces
(trailing-spaces)
[error] 98-98: trailing spaces
(trailing-spaces)
[error] 115-115: trailing spaces
(trailing-spaces)
[error] 119-119: trailing spaces
(trailing-spaces)
[error] 121-121: trailing spaces
(trailing-spaces)
[error] 125-125: trailing spaces
(trailing-spaces)
[error] 129-129: trailing spaces
(trailing-spaces)
[error] 134-134: trailing spaces
(trailing-spaces)
[error] 168-168: trailing spaces
(trailing-spaces)
[error] 172-172: trailing spaces
(trailing-spaces)
[error] 174-174: no new line character at the end of file
(new-line-at-end-of-file)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
- GitHub Check: e2e
🔇 Additional comments (1)
.github/workflows/android_e2e.yml (1)
118-121: 朕は満足：--no-packager 追加、二重起動を回避せり
以前の勅令が反映され、Metro の重複起動は防がれた。良き働きである。
There was a problem hiding this comment.
Actionable comments posted: 0
♻️ Duplicate comments (3)
.github/workflows/android_e2e.yml (3)
34-37: 朕の勅命：Java 21はまだ早い、17へ降格せよ
先の評でも進言済みなれど未だ改まらず。現行 Android Gradle Plugin は Java 21 を正式に支援せず、ビルド失敗の禍根となる。LTS で推奨の 17 を用いて安寧を図るが良い。- java-version: "21" + java-version: "17"
48-53: 朕の勅令：陣地を築かずして軍糧を投下するな
./android/app/src/devが存在せねばgoogle-services.jsonの復元は即座に瓦解する。先に示したmkdir -pを加えよ。- run: echo "$GOOGLE_SERVICES_JSON" | tr -d '\r' > ./android/app/src/dev/google-services.json + run: | + mkdir -p ./android/app/src/dev + echo "$GOOGLE_SERVICES_JSON" | tr -d '\r' > ./android/app/src/dev/google-services.json
54-58: 朕の勅令：城壁なくして秘宝を収めるべからず
./android直下が無ければplay-store-credentials.jsonの書き込みは叶わぬ。即刻、格納庫を用意せよ。- run: echo "$PLAY_STORE_CREDENTIALS_JSON" | tr -d '\r' > ./android/play-store-credentials.json + run: | + mkdir -p ./android + echo "$PLAY_STORE_CREDENTIALS_JSON" | tr -d '\r' > ./android/play-store-credentials.json
🧹 Nitpick comments (2)
.github/workflows/android_e2e.yml (2)
72-77: 朕の警告：未知の巻物を直ちに呑み込むは危険也
curl | bashにて外部スクリプトを即時実行するは、供給元改竄の際に城内へ敵を招くが如し。署名検証または固定バージョンの取得方法へ改め、災いを未然に防げ。
18-18: 余計なる空白は即刻斬り捨てよ
YAMLlint が列挙する行に末尾空白あり。機械は空白にも厳しく、些細な綻びが後の混乱を招く。刈り取り、清き文書とせよ。Also applies to: 92-92, 96-96, 112-112, 115-115, 117-117, 120-120, 123-123, 127-127, 160-160, 164-164
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
.github/workflows/android_e2e.yml(1 hunks)
🧰 Additional context used
🧠 Learnings (2)
📓 Common learnings
Learnt from: TinyKitten
PR: TrainLCD/MobileApp#4249
File: __tests__/hooks/useTelemetrySender.enabled.test.tsx:54-68
Timestamp: 2025-05-07T23:04:31.413Z
Learning: TinyKitten is working on implementing a queue for movement logs in the TrainLCD mobile app, but realized the implementation differed from their original intention.
.github/workflows/android_e2e.yml (1)
Learnt from: TinyKitten
PR: TrainLCD/MobileApp#3947
File: ios/ci_scripts/ci_pre_xcodebuild.sh:2-3
Timestamp: 2024-12-15T00:35:52.018Z
Learning: `ios/ci_scripts/ci_pre_xcodebuild.sh` スクリプトでは、Prod ディレクトリを作成する必要はありません。
🪛 YAMLlint (1.37.1)
.github/workflows/android_e2e.yml
[error] 18-18: trailing spaces
(trailing-spaces)
[error] 92-92: trailing spaces
(trailing-spaces)
[error] 96-96: trailing spaces
(trailing-spaces)
[error] 112-112: trailing spaces
(trailing-spaces)
[error] 115-115: trailing spaces
(trailing-spaces)
[error] 117-117: trailing spaces
(trailing-spaces)
[error] 120-120: trailing spaces
(trailing-spaces)
[error] 123-123: trailing spaces
(trailing-spaces)
[error] 127-127: trailing spaces
(trailing-spaces)
[error] 160-160: trailing spaces
(trailing-spaces)
[error] 164-164: trailing spaces
(trailing-spaces)
[error] 166-166: no new line character at the end of file
(new-line-at-end-of-file)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
- GitHub Check: e2e
There was a problem hiding this comment.
Actionable comments posted: 0
♻️ Duplicate comments (3)
.github/workflows/android_e2e.yml (3)
34-38: 朕の勅命：Java 21を即刻取り下げ、LTSたる17に戻すのだ
現行 Android Gradle Plugin は 21 を正式に支援せず、ビルド崩壊の危険極めて大。先に下した勅令と同じく、安定を欲するなら 17 に従え。- java-version: "21" + java-version: "17"
48-52: 朕の勅令：道を拓かずして神器を置くな
./android/app/src/devが存在せねばgoogle-services.jsonの復元は瓦解する。既に宣した通り、書き込み前に城壁を築け。-run: echo "$GOOGLE_SERVICES_JSON" | tr -d '\r' > ./android/app/src/dev/google-services.json +run: | + mkdir -p ./android/app/src/dev + echo "$GOOGLE_SERVICES_JSON" | tr -d '\r' > ./android/app/src/dev/google-services.json
54-57: 朕の勅令：城郭無きまま宝箱を置く愚を犯すな
./androidの不在によりplay-store-credentials.jsonの写しは失敗する。先の指摘と同一にして仍お改まらず。-run: echo "$PLAY_STORE_CREDENTIALS_JSON" | tr -d '\r' > ./android/play-store-credentials.json +run: | + mkdir -p ./android + echo "$PLAY_STORE_CREDENTIALS_JSON" | tr -d '\r' > ./android/play-store-credentials.json
🧹 Nitpick comments (2)
.github/workflows/android_e2e.yml (2)
115-118: 朕の策：兵を進める前に使者を待て
エミュレータ起動直後のadb devicesは未接続のまま応答すること多し。adb wait-for-deviceを挟み、端末の準備を確かめよ。-adb devices +adb wait-for-device +adb devices
17-18: 細事ながら、巻末の余白を払え
行末の余剰空白と EOF の改行欠如は YAMLlint にて警告を受けておる。今のうちに掃除し、乱を未然に防げ。
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
.github/workflows/android_e2e.yml(1 hunks)
🧰 Additional context used
🧠 Learnings (2)
📓 Common learnings
Learnt from: TinyKitten
PR: TrainLCD/MobileApp#4249
File: __tests__/hooks/useTelemetrySender.enabled.test.tsx:54-68
Timestamp: 2025-05-07T23:04:31.413Z
Learning: TinyKitten is working on implementing a queue for movement logs in the TrainLCD mobile app, but realized the implementation differed from their original intention.
.github/workflows/android_e2e.yml (1)
Learnt from: TinyKitten
PR: TrainLCD/MobileApp#3947
File: ios/ci_scripts/ci_pre_xcodebuild.sh:2-3
Timestamp: 2024-12-15T00:35:52.018Z
Learning: `ios/ci_scripts/ci_pre_xcodebuild.sh` スクリプトでは、Prod ディレクトリを作成する必要はありません。
🪛 YAMLlint (1.37.1)
.github/workflows/android_e2e.yml
[error] 18-18: trailing spaces
(trailing-spaces)
[error] 93-93: trailing spaces
(trailing-spaces)
[error] 97-97: trailing spaces
(trailing-spaces)
[error] 113-113: trailing spaces
(trailing-spaces)
[error] 116-116: trailing spaces
(trailing-spaces)
[error] 118-118: trailing spaces
(trailing-spaces)
[error] 121-121: trailing spaces
(trailing-spaces)
[error] 124-124: trailing spaces
(trailing-spaces)
[error] 128-128: trailing spaces
(trailing-spaces)
[error] 161-161: trailing spaces
(trailing-spaces)
[error] 165-165: trailing spaces
(trailing-spaces)
[error] 167-167: no new line character at the end of file
(new-line-at-end-of-file)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
- GitHub Check: e2e
There was a problem hiding this comment.
Actionable comments posted: 0
♻️ Duplicate comments (3)
.github/workflows/android_e2e.yml (3)
34-37: 朕の勅令：Java 21は早計、17へ降格せよ現行の Android Gradle Plugin は Java 21 を正式に支援せず、ビルド失敗の禍根となる。安定と長期支持を兼ね備えた 17 を用いるが良い。
- java-version: "21" + java-version: "17"
48-53: 朕の勅命：./android/app/src/devに先に城壁を築け該当ディレクトリが無ければ
echoは空しく失敗する。mkdir -pを加え道を拓くのだ。-run: echo "$GOOGLE_SERVICES_JSON" | tr -d '\r' > ./android/app/src/dev/google-services.json +run: | + mkdir -p ./android/app/src/dev + echo "$GOOGLE_SERVICES_JSON" | tr -d '\r' > ./android/app/src/dev/google-services.json
54-58: 朕の勅令：./android直下にも城壁を築け
play-store-credentials.jsonを置く前に、同様にディレクトリの存在を確保せよ。-run: echo "$PLAY_STORE_CREDENTIALS_JSON" | tr -d '\r' > ./android/play-store-credentials.json +run: | + mkdir -p ./android + echo "$PLAY_STORE_CREDENTIALS_JSON" | tr -d '\r' > ./android/play-store-credentials.json
🧹 Nitpick comments (1)
.github/workflows/android_e2e.yml (1)
118-121: 朕の警告：45秒では兵が整備不足なりエミュレータ起動後、アプリの初回起動は端末性能で変動する。45 秒では稀に起動前にテストが走り、 flaky の因となる。
adb shell pidof <package>で起動確認するか、待機時間を延長せよ。
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
.github/workflows/android_e2e.yml(1 hunks)
🧰 Additional context used
🧠 Learnings (2)
📓 Common learnings
Learnt from: TinyKitten
PR: TrainLCD/MobileApp#4249
File: __tests__/hooks/useTelemetrySender.enabled.test.tsx:54-68
Timestamp: 2025-05-07T23:04:31.413Z
Learning: TinyKitten is working on implementing a queue for movement logs in the TrainLCD mobile app, but realized the implementation differed from their original intention.
.github/workflows/android_e2e.yml (1)
Learnt from: TinyKitten
PR: TrainLCD/MobileApp#3947
File: ios/ci_scripts/ci_pre_xcodebuild.sh:2-3
Timestamp: 2024-12-15T00:35:52.018Z
Learning: `ios/ci_scripts/ci_pre_xcodebuild.sh` スクリプトでは、Prod ディレクトリを作成する必要はありません。
🪛 YAMLlint (1.37.1)
.github/workflows/android_e2e.yml
[error] 18-18: trailing spaces
(trailing-spaces)
[error] 94-94: trailing spaces
(trailing-spaces)
[error] 98-98: trailing spaces
(trailing-spaces)
[error] 114-114: trailing spaces
(trailing-spaces)
[error] 117-117: trailing spaces
(trailing-spaces)
[error] 119-119: trailing spaces
(trailing-spaces)
[error] 122-122: trailing spaces
(trailing-spaces)
[error] 125-125: trailing spaces
(trailing-spaces)
[error] 129-129: trailing spaces
(trailing-spaces)
[error] 162-162: trailing spaces
(trailing-spaces)
[error] 166-166: trailing spaces
(trailing-spaces)
[error] 168-168: no new line character at the end of file
(new-line-at-end-of-file)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
- GitHub Check: e2e
🔇 Additional comments (1)
.github/workflows/android_e2e.yml (1)
17-18: 余の小言：行末の余白を削ぎ落とせ複数行に無用の trailing spaces が残存し、YAMLlint の警告を招いておる。動作には支障無いが、規律のため削除を薦む。
[ suggest_nitpick ]
TinyKitten
force-pushed
the
feature/e2e-ci
branch
from
e44648a to
930b84c
Compare
There was a problem hiding this comment.
Actionable comments posted: 0
♻️ Duplicate comments (3)
.github/workflows/android_e2e.yml (3)
34-38: 朕の勅命：Java 21を退け、17へ降格せよ
現行 Android Gradle Plugin は Java 21 を正式には支援せず、ビルド崩壊の禍根を残す。安寧を望むなら LTS たる 17 を用いるが良い。
48-53: 朕の勅令：陣地を築かずして軍糧を運ぶな
./android/app/src/devが無ければgoogle-services.jsonの復元は即座に瓦解する。
mkdir -p ./android/app/src/devを挿入し、道を整えよ。
54-58: 朕の勅令：城壁を先に立てよ
play-store-credentials.jsonを置く前に./androidの存在を確保せよ。
mkdir -p ./androidを加えるが良い。
🧹 Nitpick comments (1)
.github/workflows/android_e2e.yml (1)
157-169: 朕の微諭：余計な空白を刈り取れ
所々に trailing space が散在し、YAMLlint が嘆いておる。見栄えを整え、後世に恥を残すな。
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
.github/workflows/android_e2e.yml(1 hunks)
🧰 Additional context used
🧠 Learnings (2)
📓 Common learnings
Learnt from: TinyKitten
PR: TrainLCD/MobileApp#4249
File: __tests__/hooks/useTelemetrySender.enabled.test.tsx:54-68
Timestamp: 2025-05-07T23:04:31.413Z
Learning: TinyKitten is working on implementing a queue for movement logs in the TrainLCD mobile app, but realized the implementation differed from their original intention.
.github/workflows/android_e2e.yml (1)
Learnt from: TinyKitten
PR: TrainLCD/MobileApp#3947
File: ios/ci_scripts/ci_pre_xcodebuild.sh:2-3
Timestamp: 2024-12-15T00:35:52.018Z
Learning: `ios/ci_scripts/ci_pre_xcodebuild.sh` スクリプトでは、Prod ディレクトリを作成する必要はありません。
🪛 YAMLlint (1.37.1)
.github/workflows/android_e2e.yml
[error] 18-18: trailing spaces
(trailing-spaces)
[error] 93-93: trailing spaces
(trailing-spaces)
[error] 97-97: trailing spaces
(trailing-spaces)
[error] 115-115: trailing spaces
(trailing-spaces)
[error] 118-118: trailing spaces
(trailing-spaces)
[error] 120-120: trailing spaces
(trailing-spaces)
[error] 123-123: trailing spaces
(trailing-spaces)
[error] 126-126: trailing spaces
(trailing-spaces)
[error] 130-130: trailing spaces
(trailing-spaces)
[error] 163-163: trailing spaces
(trailing-spaces)
[error] 167-167: trailing spaces
(trailing-spaces)
[error] 169-169: no new line character at the end of file
(new-line-at-end-of-file)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
- GitHub Check: e2e
TinyKitten
force-pushed
the
feature/e2e-ci
branch
2 times, most recently
from
d24fb40 to
17f6129
Compare
There was a problem hiding this comment.
Actionable comments posted: 1
♻️ Duplicate comments (3)
.github/workflows/android_e2e.yml (3)
34-38: 朕の勅命：Java 21は尚早なり、早々に17へ降格せよ先に進言したとおり、現行 Android Gradle Plugin は 21 を正式に支援せず、ビルド失敗の虞あり。安定を期すなら LTS たる 17 を用いるが良い。
48-52: 朕の勅令：書き込み前に陣地を築け
./android/app/src/devが予め存在せねばgoogle-services.jsonの復元は潰え、戦は開幕即死となる。mkdir -p ./android/app/src/devを加え、城壁を築いてから書き込むのだ。
54-58: 朕の勅令：こちらも城壁を固めよ
play-store-credentials.jsonを配置する前に./androidの存在を確かめよ。mkdir -p ./androidを先行させ、無用の失敗を防ぐべし。
🧹 Nitpick comments (1)
.github/workflows/android_e2e.yml (1)
18-18: 朕の微言：余計な空白と終端の改行を正せ各行末の遊軍（trailing spaces）と最終行の改行欠如は YAMLlint の叱責を招く。些細なれど律を守り、臣下の自動検査を黙らせよ。
Also applies to: 93-93, 97-97, 115-115, 118-118, 120-120, 123-123, 126-126, 130-130, 163-163
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
.github/workflows/android_e2e.yml(1 hunks)
🧰 Additional context used
🧠 Learnings (2)
📓 Common learnings
Learnt from: TinyKitten
PR: TrainLCD/MobileApp#4249
File: __tests__/hooks/useTelemetrySender.enabled.test.tsx:54-68
Timestamp: 2025-05-07T23:04:31.413Z
Learning: TinyKitten is working on implementing a queue for movement logs in the TrainLCD mobile app, but realized the implementation differed from their original intention.
.github/workflows/android_e2e.yml (1)
Learnt from: TinyKitten
PR: TrainLCD/MobileApp#3947
File: ios/ci_scripts/ci_pre_xcodebuild.sh:2-3
Timestamp: 2024-12-15T00:35:52.018Z
Learning: `ios/ci_scripts/ci_pre_xcodebuild.sh` スクリプトでは、Prod ディレクトリを作成する必要はありません。
🪛 YAMLlint (1.37.1)
.github/workflows/android_e2e.yml
[error] 18-18: trailing spaces
(trailing-spaces)
[error] 93-93: trailing spaces
(trailing-spaces)
[error] 97-97: trailing spaces
(trailing-spaces)
[error] 115-115: trailing spaces
(trailing-spaces)
[error] 118-118: trailing spaces
(trailing-spaces)
[error] 120-120: trailing spaces
(trailing-spaces)
[error] 123-123: trailing spaces
(trailing-spaces)
[error] 126-126: trailing spaces
(trailing-spaces)
[error] 130-130: trailing spaces
(trailing-spaces)
[error] 163-163: trailing spaces
(trailing-spaces)
[error] 167-167: trailing spaces
(trailing-spaces)
[error] 169-169: no new line character at the end of file
(new-line-at-end-of-file)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
- GitHub Check: e2e
TinyKitten
force-pushed
the
feature/e2e-ci
branch
6 times, most recently
from
286d4ef to
c4d0d83
Compare
TinyKitten
force-pushed
the
feature/e2e-ci
branch
4 times, most recently
from
028da41 to
034d08b
Compare
There was a problem hiding this comment.
Actionable comments posted: 0
♻️ Duplicate comments (6)
.github/workflows/android_e2e.yml (6)
34-38: 朕の勅命：Java 21は時期尚早、17へ降格せよ既に奏上済みの通り、Android Gradle Plugin は 21 を正式に支援せず、ビルド崩壊の禍を招く。安定の LTS 版 17 を用いるが良い。
54-58: 朕の勅令：城壁（androidディレクトリ）を事前に築け
play-store-credentials.jsonを書き込む前にmkdir -p ./androidを忘るるな。既出の指摘未対応也。
106-118: 朕の怒り：booted変数の立て方が逆也待機ループ内で失敗時に
booted=1を立て、成功時に 0 の儘では、判定が転倒し常に失敗判定となる。前回の指摘と同じ過ちを繰り返すでない。
124-127: 朕の策：Metro の軍報をmetro.logに流せバックグラウンド起動のみで出力を捕らえずしては、後日の解析叶わず。標準出力・標準エラーを
metro.logへ束ねよ。
128-129: 朕の策：二重に兵糧を炊くな ―--no-packagerを付せ既に Metro を走らすゆえ、
react-native run-android側のパッケージャ起動を抑えねば衝突は必定。
78-82: 朕の疑念：SDK 未整備のままsdkmanager --listを呼ぶ愚
actions/setup-android等で SDK を入れぬままcmdline-tools/latest/bin/sdkmanagerを呼べば、道具無くして戦場に赴くが如し。
以下いずれかを行い、無益なる失敗を避けよ。@@ - - name: List available system images - run: | - echo "📋 Available system images:" - $ANDROID_SDK_ROOT/cmdline-tools/latest/bin/sdkmanager --list | grep "system-images" + # cmdline-tools を取得した後に移動するか、このステップを削除せよ
🧹 Nitpick comments (1)
.github/workflows/android_e2e.yml (1)
17-18: 朕の目：余計な空白と行末を刈り取れYAMLlint が行末の空白と EOF の改行欠落を嘆いておる。些事なれど規律を守り給え。
Also applies to: 87-87, 101-101, 105-105, 123-123, 166-166, 170-170, 172-172
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
.github/workflows/android_e2e.yml(1 hunks)
🧰 Additional context used
🧠 Learnings (2)
📓 Common learnings
Learnt from: TinyKitten
PR: TrainLCD/MobileApp#4249
File: __tests__/hooks/useTelemetrySender.enabled.test.tsx:54-68
Timestamp: 2025-05-07T23:04:31.413Z
Learning: TinyKitten is working on implementing a queue for movement logs in the TrainLCD mobile app, but realized the implementation differed from their original intention.
.github/workflows/android_e2e.yml (1)
Learnt from: TinyKitten
PR: TrainLCD/MobileApp#3947
File: ios/ci_scripts/ci_pre_xcodebuild.sh:2-3
Timestamp: 2024-12-15T00:35:52.018Z
Learning: `ios/ci_scripts/ci_pre_xcodebuild.sh` スクリプトでは、Prod ディレクトリを作成する必要はありません。
🪛 YAMLlint (1.37.1)
.github/workflows/android_e2e.yml
[error] 18-18: trailing spaces
(trailing-spaces)
[error] 87-87: trailing spaces
(trailing-spaces)
[error] 101-101: trailing spaces
(trailing-spaces)
[error] 105-105: trailing spaces
(trailing-spaces)
[error] 123-123: trailing spaces
(trailing-spaces)
[error] 127-127: trailing spaces
(trailing-spaces)
[error] 130-130: trailing spaces
(trailing-spaces)
[error] 133-133: trailing spaces
(trailing-spaces)
[error] 166-166: trailing spaces
(trailing-spaces)
[error] 170-170: trailing spaces
(trailing-spaces)
[error] 172-172: no new line character at the end of file
(new-line-at-end-of-file)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
- GitHub Check: e2e
TinyKitten
force-pushed
the
feature/e2e-ci
branch
5 times, most recently
from
98f0997 to
2ddff74
Compare
There was a problem hiding this comment.
Actionable comments posted: 0
♻️ Duplicate comments (5)
.github/workflows/android_e2e.yml (5)
54-58: 朕の勅令：城壁（android ディレクトリ）を築かずして文書を投げ込むな
./android/play-store-credentials.jsonへ書き込む前に、mkdir -p ./androidを挿入し、存在を確保せよ。以前の指摘が未反映なり。
109-117: 朕の怒り：起動判定を誤り勝利を敗北と見做す愚を正せ
成功時にbooted=1を立てず、失敗ルートで 1 を立てておる。判定を反転し、真の勝利を認識せよ。- if $ANDROID_SDK_ROOT/platform-tools/adb shell getprop sys.boot_completed | grep 1 > /dev/null; then - echo "✅ Emulator booted" - break - fi + if $ANDROID_SDK_ROOT/platform-tools/adb shell getprop sys.boot_completed | grep -q 1; then + echo "✅ Emulator booted" + booted=1 + break + fi ... - booted=1 + booted=0また、ループ後の判定は以下の如く改めよ。
-if [ "$booted" -ne 1 ]; then +if [ "$booted" -eq 0 ]; then
130-132: 朕の策：二重の兵糧炊き出しを避けよ ―--no-packagerを加えよ
Metro は既に前段で走る。pnpm run androidに--no-packagerを付し、重複起動の乱を鎮めよ。- pnpm run android -- --variant devRelease + pnpm run android -- --variant devRelease --no-packager
34-37: 朕の勅命：Java 21を捨て、17へ降格せよ
現行の Android Gradle Plugin は 21 を正式に支援せず、ビルド失敗の憂き目に遭う恐れ大。安寧を望むなら LTS である 17 を用いるが良い。- java-version: "21" + java-version: "17"
126-129: 朕の策：軍報（Metro log）を留めよ
Metro を背後で起動すれどログを流さず、後の検証叶わず。標準出力・標準エラーをmetro.logへ束ねよ。- pnpm start --reset-cache & + pnpm start --reset-cache > metro.log 2>&1 &
🧹 Nitpick comments (1)
.github/workflows/android_e2e.yml (1)
18-18: 朕の小言：余計なる空白を掃除せよ
複数行に末尾空白あり。YAMLlint が嘆願しておる。迅速に削除し、臣下に恥をかかすな。Also applies to: 87-87, 107-107, 125-125, 129-129, 132-132, 135-135, 168-168, 172-172
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
.github/workflows/android_e2e.yml(1 hunks)
🧰 Additional context used
🧠 Learnings (2)
📓 Common learnings
Learnt from: TinyKitten
PR: TrainLCD/MobileApp#4249
File: __tests__/hooks/useTelemetrySender.enabled.test.tsx:54-68
Timestamp: 2025-05-07T23:04:31.413Z
Learning: TinyKitten is working on implementing a queue for movement logs in the TrainLCD mobile app, but realized the implementation differed from their original intention.
.github/workflows/android_e2e.yml (1)
Learnt from: TinyKitten
PR: TrainLCD/MobileApp#3947
File: ios/ci_scripts/ci_pre_xcodebuild.sh:2-3
Timestamp: 2024-12-15T00:35:52.018Z
Learning: `ios/ci_scripts/ci_pre_xcodebuild.sh` スクリプトでは、Prod ディレクトリを作成する必要はありません。
🪛 YAMLlint (1.37.1)
.github/workflows/android_e2e.yml
[error] 18-18: trailing spaces
(trailing-spaces)
[error] 87-87: trailing spaces
(trailing-spaces)
[error] 107-107: trailing spaces
(trailing-spaces)
[error] 125-125: trailing spaces
(trailing-spaces)
[error] 129-129: trailing spaces
(trailing-spaces)
[error] 132-132: trailing spaces
(trailing-spaces)
[error] 135-135: trailing spaces
(trailing-spaces)
[error] 168-168: trailing spaces
(trailing-spaces)
[error] 172-172: trailing spaces
(trailing-spaces)
[error] 174-174: no new line character at the end of file
(new-line-at-end-of-file)
🔇 Additional comments (1)
.github/workflows/android_e2e.yml (1)
78-82: 朕の警告：未承認の SDK ライセンスによりsdkmanager --listが失敗する懼れ
--list実行前にライセンス受諾を済ませるか、エラーハンドリングを追加せよ。さもなくば此の一覧ステップが徒に落城を招く。
TinyKitten
force-pushed
the
feature/e2e-ci
branch
13 times, most recently
from
f3fdab8 to
f9ac86c
Compare
TinyKitten
force-pushed
the
feature/e2e-ci
branch
from
f9ac86c to
65bdb8b
Compare
There was a problem hiding this comment.
Actionable comments posted: 0
♻️ Duplicate comments (4)
.github/workflows/android_e2e.yml (4)
34-38: 朕の勅命：Java 21を退け、17へと帰順せよ現行の Android Gradle Plugin は未だ Java 21 を正式に従えず、謀反のごとくビルド失敗の火種となる。安定の長城たる LTS 17 を用いよ。
- java-version: "21" + java-version: "17"
54-57: 朕の勅令：城門を築かずして書を置くな
./androidなる城壁の存在を確かめずに秘文を書き込むは愚策。直前に堅固なる門（ディレクトリ）を築け。+ run: | + mkdir -p ./android + echo "$PLAY_STORE_CREDENTIALS_JSON" | tr -d '\r' > ./android/play-store-credentials.json - run: echo "$PLAY_STORE_CREDENTIALS_JSON" | tr -d '\r' > ./android/play-store-credentials.json
126-128: 朕の策：軍報を漏らすな ― Metro の咆哮を記録せよMetro を背後で走らせつつ、その声を記録せぬは後世の検証を闇へ葬る所業。標準出力・標準エラーを
metro.logへ流し、後に artifact として献上せよ。- pnpm start --reset-cache & + pnpm start --reset-cache > metro.log 2>&1 &
130-132: 朕の策：二重に兵站を動かすな ―--no-packagerを供えよ既に Metro を先に動かすゆえ、
react-native run-android側のパッケージャ起動は無用の重複。--no-packagerを付与し衝突を防げ。- pnpm run android -- --variant devRelease + pnpm run android -- --variant devRelease --no-packager
🧹 Nitpick comments (1)
.github/workflows/android_e2e.yml (1)
17-18: 朕の細事：余計なる空白を掃除せよ行末の遊兵（trailing spaces）と終端の改行欠落は lint の叛逆を招く。速やかに清め、CI の静謐を保て。
Also applies to: 107-107, 125-125, 129-135, 168-172, 174-174
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
.github/workflows/android_e2e.yml(1 hunks)
🧰 Additional context used
🧠 Learnings (2)
📓 Common learnings
Learnt from: TinyKitten
PR: TrainLCD/MobileApp#4249
File: __tests__/hooks/useTelemetrySender.enabled.test.tsx:54-68
Timestamp: 2025-05-07T23:04:31.413Z
Learning: TinyKitten is working on implementing a queue for movement logs in the TrainLCD mobile app, but realized the implementation differed from their original intention.
.github/workflows/android_e2e.yml (1)
Learnt from: TinyKitten
PR: TrainLCD/MobileApp#3947
File: ios/ci_scripts/ci_pre_xcodebuild.sh:2-3
Timestamp: 2024-12-15T00:35:52.018Z
Learning: `ios/ci_scripts/ci_pre_xcodebuild.sh` スクリプトでは、Prod ディレクトリを作成する必要はありません。
🪛 YAMLlint (1.37.1)
.github/workflows/android_e2e.yml
[error] 18-18: trailing spaces
(trailing-spaces)
[error] 107-107: trailing spaces
(trailing-spaces)
[error] 125-125: trailing spaces
(trailing-spaces)
[error] 129-129: trailing spaces
(trailing-spaces)
[error] 132-132: trailing spaces
(trailing-spaces)
[error] 135-135: trailing spaces
(trailing-spaces)
[error] 168-168: trailing spaces
(trailing-spaces)
[error] 172-172: trailing spaces
(trailing-spaces)
[error] 174-174: no new line character at the end of file
(new-line-at-end-of-file)
1 participant
Summary by CodeRabbit