Improve/api and packaging#3
Merged
Merged
Conversation
| package-nuget: | ||
| name: Package NuGet package | ||
| needs: build-native | ||
| runs-on: ubuntu-24.04 |
Contributor
There was a problem hiding this comment.
NuGet consumption is currently only tested on Linux, although package publishes native assets for win-x64, linux-x64 and osx-x64. There is a risk of missing the broken packaging path for Windows/macOS can safely reach the release unnoticed
Contributor
There was a problem hiding this comment.
collect .nupkg once, and then check its consumption on each target OS with a separate matrix-job. Now package-nuget and smoke test live only on ubuntu-24.04, although the package is assembled from Windows/Linux/macOS native artifacts, and .NET/NuGet choose native assets by runtimes/{ rid }/native/ for a specific runtime. Therefore, a successful Linux run does not validate win-x64 and osx-x64 boot paths.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds NuGet packaging and for both .NET and Unity.
The repository now supports:
annoy.net.unitypackageAnnoy.NetNuGet packageWhat changed
Shared managed source
annoy_sharp/Annoy.cssrc/Annoy.Net/Annoy.Net.csprojUnity packaging improvements
asmdefplatform restrictions so the managed assembly is no longer Windows-onlySamples~Tests/Runtime.unitypackagegeneration so it imports cleanly intoAssets/Annoy.NETunitypackageincludes native libraries for Windows, Linux, and macOSNuGet packaging
Annoy.Net.nupkgfor:win-x64linux-x64osx-x64PackageReferenceCI and release pipeline
annoy.net.unitypackageAnnoy.Net.nupkgNUGET_API_KEYis configuredValidation
Validated locally with:
.unitypackagegeneration.nupkggenerationPackageReferenceNotes