UUIDHelper improvements#25
Open
bigsir24 wants to merge 4 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes UUIDHelper freezing your game when looking at signs or flags if the UUID was invalid or could not be fetched.UUIDHelper#getNameI18nFromUUIDshould now be used for getting usernames if necessary, as it will return two different translated keys instead of null, based on why it couldn't get the username:None- The UUID was null or 0 (which is effectively invalid), signifies that a sign/flag has no ownerUnknown- The UUID could not be matched to a username for various reasonsThe UUID map should now also be updated when a player joins the server.
Misc: