fix: Pass preRun as shell script instead of splitting on whitespace#340
Open
jbinto wants to merge 1 commit into
Open
fix: Pass preRun as shell script instead of splitting on whitespace#340jbinto wants to merge 1 commit into
jbinto wants to merge 1 commit into
Conversation
strings.Fields() split multi-line preRun commands into flat tokens, causing only the first command to execute. Wrap the entire script in `bash` and `-euo pipefail` so newlines are preserved as command separators, and any failing command fails the entire script immediately.
jbinto
commented
Apr 7, 2026
| func (d *Docker) RunService(ctx context.Context, serviceName, cmd string) error { | ||
| tracker := progress.TrackerFromContext(ctx) | ||
| script := strings.TrimSpace(cmd) | ||
| shellCmd := []string{"bash", "-c", "set -euo pipefail\n" + script} |
Contributor
Author
There was a problem hiding this comment.
this is the important part, the rest is just helpful logging
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
strings.Fields() split multi-line preRun commands into flat tokens, causing only the first command to execute. Wrap the entire script in
bashand-euo pipefailso newlines are preserved as command separators, and any failing command fails the entire script immediately.