Fix skill level task handling, add XP task handling, and improve data synchronization

[Darkforge317]

Added real-time tracking for Skill XP tasks and fixed several issues related to task synchronization, validation, serialization, and startup initialization.

Key improvements include:

• Skill XP tasks now update from live XP gains and re-evaluate correctly after login.
• Skill Level task updates now consistently trigger notifications, UI updates, and persistence.
• Fixed an NPE that could occur when loading large prerequisite chains such as Heroes' Quest.
• Added safeguards against malformed imports and missing serialized data.
• Fixed task creation ordering that could result in incorrect progress values being saved.

---

Technical Changes

1. Skill Task Synchronization and XP Event Tracking

Skill level changes were being calculated correctly but did not consistently trigger notifications, UI updates, or persistence. In addition, SkillXpTask instances were not responding to live XP gain events and were not re-evaluated during login.

• Refactored onStatChanged into a structure that supports multiple skill-based task types.
• Added event-driven updates for both SkillLevelTask and SkillXpTask.
• Trigger UI refreshes, notifications, and persistence when task progress changes.
• Added a save optimization flag to reduce unnecessary disk writes.
• Renamed xp to targetSkillXp for consistency with other skill milestone models.

2. Login Synchronization

Task state was not reliably synchronized when a player logged into the game, which could leave goals displaying outdated progress until another qualifying event occurred.

Implemented a login initialization pass within onGameStateChanged.
The startup routine waits until skill data has been populated (client.getRealSkillLevel(Skill.ATTACK) > 0) before performing validation. Once player data is available, it executes:

• refreshQuestTasks()
• refreshSkillLevelTasks()
• refreshSkillXpTasks()

The UI is then refreshed to reflect the updated task state.

3. Thread-Safe Prerequisite Validation (refreshAllTasks)

Complex prerequisite validation could occur on the Swing event thread, leading to synchronization issues and inconsistent task state updates.

Introduced refreshAllTasks(Runnable onCompleteUIHandler).

• Validation now executes entirely on RuneLite's clientThread.
• UI updates are deferred until validation completes.
• Heavy prerequisite traversal is kept off the Swing thread.

4. Defensive Handling for Missing Data

Malformed imports or partially initialized task objects could trigger NPEs and leave the UI unable to render.

• Added a fallback in Task.getStatus() that returns Status.NOT_STARTED when status data is missing.
• Added lazy initialization in Goal.getTasks() to ensure missing task collections are replaced with an empty ReorderableList<>.

5. Task Creation and Serialization Ordering

The task insertion handler fired a blocking, synchronous goalManager.save() straight on the main UI thread before player statistics were evaluated in memory resulting in incorrect values such as current_skill_xp = 0 being written to disk. This caused fresh tasks to write uninitialized primitive states directly to the disk file cache.

Restructured the loop to invoke taskUpdateService.update(task) on the game thread prior to serialization. This forces the task to immediately query current live client milestones, caching the real statistics in RAM before goalManager.save() writes the payload to disk. Moved both the file save handle and notifyTask off the UI thread entirely to insulate the Swing engine from blocking disk I/O.

---

Verification

• Malformed JSON Import — Importing data with a missing items field no longer causes UI failures. Empty goals load correctly.
• Quest Prerequisites — Large prerequisite chains such as Heroes' Quest validate correctly and update task states immediately when applicable.
• Live XP Tracking — XP milestones update immediately from gameplay events, refresh the sidebar, trigger notifications, and persist the correct XP values.