Skip to content

Perturbations output & renamed species variables#29

Merged
cgiovanetti merged 9 commits into
mainfrom
perturbations_output
May 19, 2026
Merged

Perturbations output & renamed species variables#29
cgiovanetti merged 9 commits into
mainfrom
perturbations_output

Conversation

@TonyZhou729

Copy link
Copy Markdown
Owner
  1. Added new perturbations output option, updated notebook with SIDR example
  2. Renamed delta_idx, num_moments to first_idx, num_equations respectively

@TonyZhou729 TonyZhou729 requested a review from cgiovanetti May 16, 2026 00:38
@cgiovanetti

Copy link
Copy Markdown
Collaborator

Is the photon modes[self.first_idx + self.num_F_ell_modes+1] not of interest?

@TonyZhou729

Copy link
Copy Markdown
Owner Author

Not most of the time, the Cl source functions only need the l=0 and l=2 polarization modes. The user could inherit from Photon and define their own output_perturbations if they really wanted to see the other modes.

@cgiovanetti cgiovanetti left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks terrific. Just need to pull and run some time tests and then I will merge.

@cgiovanetti cgiovanetti merged commit ea203b3 into main May 19, 2026
1 check passed
@TonyZhou729 TonyZhou729 deleted the perturbations_output branch June 2, 2026 19:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants