DO NOT MERGE: Visualisation of my changes#14
Draft
Tom-Newton wants to merge 19 commits into
Draft
Conversation
* Working with Spark 3.5.0 * Use SparkSession instead of deprecated SQLContext on the python side * Correction in init * Update tests for new spark session configuration
* Set spark log level to error * Run all tests with and without codegen * Re-name * Update tests to include product of all the things that were originally tested * Tests with no backward rows to match with * Add tests for empty dataframes * Add tests for preserving nulls in the input * Add tests for preserving nulls when tolerance is used * Fix codegen__left_join_some_rows_have_no_backwards_match * Fix interpreted__left_join_right_dataframe_is_empty * Fix interpretted__inner_join_searching_backward_for_matches_with_tolerance * Tidy * Remove debug `.show()`s
* Start tests * Valid tests * Fix codegen version * Tests with duplicate rows * Delete unnecessary code. It was a legacy of the normal join's multi matching behaviour * Working inner joins with more code removed and tolerance applied inside main search loop * Working inner join * Tidy * Very minor clean ups * Remove some unnecessary branching * Fix schema assertion for left_join_duplicate_join_keys * Remove unneeded bound condition * Fix schema assertions for nulls in join keys * Update comments and rename variables * Auto-format * Remove slightly misleading comment * Remove completed TODO comment * More comment adjustments
* Remove `condition` from exec code * Fail physical planning if there are non-equi conditions * Add test * Throw an exception
* Initial testcase * Correct test * Attempt to create a new version of normal `.join` * Delete mess * Switch to new spark extensions framework * First explicit pitJoin compiles * In progress: create new entrypoint to PIT join * Working test * All scala tests working * Create python side joinPIT to replace context * Rename some paramaters * Update parameter order in tests * Orgnise imports * Tidy
* Make spark session an explicit argument * Update Readme
* Use updated spark * Upgrade other deps * Update python side spark dependency * Bump the version * Add wheel to requirements * version bump python side too
* Re-order methods to make it more easily comparable to native spark SortMergeJoin * Another comparison comment
* Bump versions * Working build * Use the row encoder as per up to date spark * All tests pass * Bump python spark version * Update README and make it 0.8.0
* Initial test and implementation * Use column expression instead of modifying dataframe column * Update implementation based on an example from inside spark * Bump versions * Remove unused import * Unabbreviate * Switch to AnalysisException
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.