Skip to content

✨ 核心资源不再计算修补建筑的资源 & ✨ 显示建造时间 & 🎨 onDrawSelect & ✨ 分离扫描模式的鼠标信息 - #146

Merged
way-zer merged 10 commits into
TinyLake:mainfrom
MinRi2:main
Jul 15, 2026
Merged

✨ 核心资源不再计算修补建筑的资源 & ✨ 显示建造时间 & 🎨 onDrawSelect & ✨ 分离扫描模式的鼠标信息#146
way-zer merged 10 commits into
TinyLake:mainfrom
MinRi2:main

Conversation

@MinRi2

@MinRi2 MinRi2 commented Jul 13, 2026

Copy link
Copy Markdown

No description provided.

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request refactors and modularizes custom selection rendering by moving logic out of client patches and into dedicated classes like RenderExt and the new ConstructSelect helper. It also introduces a new 'Display Mouse Info' setting to show coordinates and distance under the cursor, and adds a derelict repair check in NewCoreItemsDisplay.

Feedback highlights two issues:

  1. In NewCoreItemsDisplay.java, the derelict repair check uses tile == null || ... which incorrectly skips plans with null tiles instead of counting them in resource requirements. This should be changed to tile != null && ....
  2. In ConstructSelect.java, the static fields used for smoothing construction speed are shared across all building instances, causing glitchy calculations when switching between hovered buildings. Tracking the hovered building ID and resetting the state accordingly is recommended.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

Comment thread src/mindustryX/features/ui/NewCoreItemsDisplay.java
Comment thread src/mindustryX/features/draw/ConstructSelect.java
@way-zer
way-zer merged commit 24cc16b into TinyLake:main Jul 15, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants