✨ 核心资源不再计算修补建筑的资源 & ✨ 显示建造时间 & 🎨 onDrawSelect & ✨ 分离扫描模式的鼠标信息 - #146
Merged
Conversation
There was a problem hiding this comment.
Code Review
This pull request refactors and modularizes custom selection rendering by moving logic out of client patches and into dedicated classes like RenderExt and the new ConstructSelect helper. It also introduces a new 'Display Mouse Info' setting to show coordinates and distance under the cursor, and adds a derelict repair check in NewCoreItemsDisplay.
Feedback highlights two issues:
- In
NewCoreItemsDisplay.java, the derelict repair check usestile == null || ...which incorrectly skips plans with null tiles instead of counting them in resource requirements. This should be changed totile != null && .... - In
ConstructSelect.java, the static fields used for smoothing construction speed are shared across all building instances, causing glitchy calculations when switching between hovered buildings. Tracking the hovered building ID and resetting the state accordingly is recommended.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.