Prifddinas progress#387
Open
Arcuez wants to merge 2 commits into
Open
Conversation
Added Prifddinas obstacle course, with portal support. The only thing that lacks is the third failable obstacle, as I'm not sure how to test this
-fixed portal behavior -fixed stop obstacle behavior
Arcuez
marked this pull request as ready for review
June 29, 2025 19:46
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
My coding knowledge is EXTREMELY limited but I came up with a few fixes with the help of a friend. All these changes were made on Melleni's pull request. I don't really know how git works so I hope this ends up in the correct place.
Fixes
Fixed portal behavior
Fixed stop obstacle behavior
To do:
1- Portals instantly have clickable color even though player is in an animation/can't interact with portal yet.
2- When a portal is clicked on, the next obstacle is instantly colored as interactable even though the portal action isn't complete.
3- Third failable obstacle.
4- The portal check relies on player distance, this makes the timing where obstacle_stop is drawn inconsistent.
5- Obstacles change color before you interact with them. So if you red click an obstacle and reach it, but cancel the action by moving away from the last tile, it acts as if you've already interacted with it, highlighting the next obstacle. This issue seems to be present across all rooftop courses.
Possible fixes:
1- Classify portals similar to how obstacles are handled
2- When a portal is clicked on, wait for player to hit certain coordinates before drawing the next obstacle as clickable.
Player coords after each portal:
36241=3275, 6105, 2
36242=2268, 3389, 2
36243=2244, 3394, 2
36244=2247, 3405, 2
36245=2253, 3415, 2
36246=2262, 3426, 0
3- Each time a hitsplat is rendered, put an if statement checking the player coordinate. If the coordinate is the tile where you drop from the 3rd failable obstacle (3275, 6146, 0), highlight the ladder (ID=36232). Else completeCourse(); , highlighting the first obstacle.
4- No clue really.
5- Not sure if this is the efficient way but, the code could check player coords after each obstacle before hiding/coloring obstacles. Or if there's another way to check if the obstacle is completed, that would work too.